Juergen Spitzmueller wrote:
>> It's also a bit unexpected, as the dialog is modeless: I.e., would make
>> different the behaviour of a "find-next" from a first "find". What if the
>> inset has been moved, or manually closed, or simply erased inbetween?
>> In any case, this is a bit more dificult,
Alfredo Braunstein wrote:
> I don't see this behaviour with 1.3.2 spellchecking, only with s&r.
Yes. Sorry for not stating it clearer. For spellchecking, your changes are a
big improvement (since the 1.3 spellchecker opened *any* footnote on his way
through the document).
> It's also a bit unex
Juergen Spitzmueller wrote:
> Juergen Spitzmueller wrote:
>> > Can you test now if there are no regressions?
>>
>> I have found one regression: LyX spellchecks ERTs
>
> Another thing:
> In 1.3, f&r sets collapsables to their original state after leaving it
> (e.g., if it finds a word in a collaps
Juergen Spitzmueller wrote:
> > Can you test now if there are no regressions?
>
> I have found one regression: LyX spellchecks ERTs
Another thing:
In 1.3, f&r sets collapsables to their original state after leaving it (e.g.,
if it finds a word in a collapsed footnote, the footnote will be collap
On Thu, Nov 06, 2003 at 12:54:42PM +0100, Juergen Spitzmueller wrote:
> Alfredo Braunstein wrote:
> > > Of course. Just keep it in mind please. IMHO spellchecking really needs
> > > some overhaul. The fact that it uncollapses collapsables literally keeps
> > > me from spellchecking my documents if
Juergen Spitzmueller wrote:
> Alfredo Braunstein wrote:
>> > Of course. Just keep it in mind please. IMHO spellchecking really needs
>> > some overhaul. The fact that it uncollapses collapsables literally
>> > keeps me from spellchecking my documents if not absolutely necessary.
>>
>> Can you test
Alfredo Braunstein wrote:
> > Of course. Just keep it in mind please. IMHO spellchecking really needs
> > some overhaul. The fact that it uncollapses collapsables literally keeps
> > me from spellchecking my documents if not absolutely necessary.
>
> Can you test now if there are no regressions?
I
Juergen Spitzmueller wrote:
> Of course. Just keep it in mind please. IMHO spellchecking really needs
> some overhaul. The fact that it uncollapses collapsables literally keeps
> me from spellchecking my documents if not absolutely necessary.
Can you test now if there are no regressions?
Thanks,
On Mon, Nov 03, 2003 at 10:10:32AM +0100, Alfredo Braunstein wrote:
> Can I apply the patch?
>
> Let me add that with the above, the following patch fixes the undo crash
> detected by Kornel (so it solves a problem that we have already, i.e. how
> to put a cursor in an arbitrary point in the tree.
On Sat, Nov 01, 2003 at 06:47:46PM +0100, Lars Gullik Bjønnes wrote:
> Can we begin by just applying the PosIterator files?
> (makes further patches easier to digest)
Yes please.
[Alfredo: As a rule of thumb: Don't _wait_ for _my_ approval. Asking
is nice, but don't let it become an obstacle.]
A
-BEGIN PGP SIGNED MESSAGE-
On Montag, 3. November 2003 12:49, Alfredo Braunstein wrote:
> > This crashes also.
> > 1.) open file
> > 2.) change some words
> > 3.) undo until commad disabled
> > 4.) Standard par -> make if oval box
> > 5.) chage something in this box
> > 6.) repeat undo unt
Kornel Benko wrote:
> -BEGIN PGP SIGNED MESSAGE-
>
> On Montag, 3. November 2003 12:21, Alfredo Braunstein wrote:
>> Kornel Benko wrote:
>> > Crash on first try to search.
>> >
>> > 1.) Open file
>> > 2.) search (no matter what)
>> > 3.) crash
>>
>> The search stuff it's not in yet, only
-BEGIN PGP SIGNED MESSAGE-
On Montag, 3. November 2003 12:39, Kornel Benko wrote:
> On Montag, 3. November 2003 12:21, Alfredo Braunstein wrote:
> > Kornel Benko wrote:
> > > Crash on first try to search.
> > >
> > > 1.) Open file
> > > 2.) search (no matter what)
> > > 3.) crash
> >
> > T
-BEGIN PGP SIGNED MESSAGE-
On Montag, 3. November 2003 12:21, Alfredo Braunstein wrote:
> Kornel Benko wrote:
> > Crash on first try to search.
> >
> > 1.) Open file
> > 2.) search (no matter what)
> > 3.) crash
>
> The search stuff it's not in yet, only the undo fix (does undo work ok
> n
Kornel Benko wrote:
> Crash on first try to search.
>
> 1.) Open file
> 2.) search (no matter what)
> 3.) crash
The search stuff it's not in yet, only the undo fix (does undo work ok
now?).
Alfredo
-BEGIN PGP SIGNED MESSAGE-
On Montag, 3. November 2003 11:17, Alfredo Braunstein wrote:
> This is the last change commited to ParIterator this morning.
>
> - Try to cvs up again (possibly removing iterators.[Ch] before that, i.e.
> check you don't have any [C]onflict/old junk from previous
Kornel Benko wrote:
> -BEGIN PGP SIGNED MESSAGE-
>
> On Montag, 3. November 2003 10:28, Alfredo Braunstein wrote:
>> Alfredo Braunstein wrote:
>> > Kornel Benko wrote:
>> >> Undo. I expected the box to disappear. And it is current cvs as of
>> >> 13:00 today + search3.diff
>> >
>> > It is
-BEGIN PGP SIGNED MESSAGE-
On Montag, 3. November 2003 10:28, Alfredo Braunstein wrote:
> Alfredo Braunstein wrote:
> > Kornel Benko wrote:
> >> Undo. I expected the box to disappear. And it is current cvs as of 13:00
> >> today + search3.diff
> >
> > It is already in current cvs (i.e. not
Alfredo Braunstein wrote:
> Kornel Benko wrote:
>
>> Undo. I expected the box to disappear. And it is current cvs as of 13:00
>> today + search3.diff
>
> It is already in current cvs (i.e. not related to search3.diff).
Can you confirm that the following patch solves the problem (and it doesn't
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| Can I apply the patch?
yes.
--
Lgb
Alfredo Braunstein wrote:
> iterator.[Ch]:
>
> I need this lockPath stuff. It is needed to place a cursor given some
> position in the document tree. In the old scheme, inset were locked
> sequentially following the cursor movement. [[Implemented in ParIterator
for
> simplicity, because we have r
Lars Gullik BjÃnnes wrote:
> [EMAIL PROTECTED] (Lars Gullik BjÃnnes) writes:
>
> | And yes, I found this better.
>
> And you should just apply this now...
Done, thanks.
Next step.
iterator.[Ch]:
I need this lockPath stuff. It is needed to place a cursor given some
position in the document tr
Lars Gullik BjÃnnes wrote:
> Sorry for not noticing this ealier, but I think (if possible) they
> should be free functions and not class functions.
No problem.
>
> Then they would look like this:
>
> bool operator==(PosIterator const & lhs,
> PosIterator const & rhs)
> {
>
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| And yes, I found this better.
And you should just apply this now...
--
Lgb
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| +bool PosIterator::operator!=(PosIterator const & a) const
| +{
| + return !operator==(a);
| +}
| +
| +
| +bool PosIterator::operator==(PosIterator const & a) const
| +{
| +
| + PosIteratorItem const & pa = a.stack_.top();
| + PosI
Alfredo Braunstein wrote:
> Is this ok (attached)?
oops wrong patch (I sent the same old one). H... retry.
> a
>
> PosIterator ParIterator::asPosIterator(lyx::pos_type)
>
> member, made friend in class PosIterator
Alfredo
? PosIterator.C-save
? PosIterator.h-save
? all.diff
? bfs.cpp
?
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
>> friend the whole PosIterator class so that forward delcaration will
>> work?
>
| Uh? What forward declaration?
the one that you are going to add.
| friend only the function in question (a contructor) would be ok?
well... yes... I am not sure if
Lars Gullik BjÃnnes wrote:
> Alfredo Braunstein <[EMAIL PROTECTED]> writes:
>
>>> Why have this here? and not int he positerator.C file?
>>
> | Because I need ParPosition which is not defined in the header file.
> | Should I put it on the header?
>
> forward delcare...
>
>>> why do they have to
Lars Gullik BjÃnnes wrote:
>>> Why have this here? and not int he positerator.C file?
>>
> | Because I need ParPosition which is not defined in the header file.
> | Should I put it on the header?
>
> forward delcare...
? I need the declaration to use it. The class declaration is on the
iterators
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> yes + some comment.
>>
>> | +using boost::prior;
>>
>> which header file include next_prior.hpp?
>
| Couldn't find out. Should I add it just in case?
yeah.
>> I wonder if there is a way, so that we don't need to
Lars Gullik BjÃnnes wrote:
> yes + some comment.
>
> | +using boost::prior;
>
> which header file include next_prior.hpp?
Couldn't find out. Should I add it just in case?
> | +PosIterator & PosIterator::operator--()
> | +{
> | + while (!stack_.empty()) {
> | + {
>
> why the stra
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> Can we begin by just applying the PosIterator files?
>> (makes further patches easier to digest)
>
| Ok, first step. Can I apply this?
yes + some comment.
| +using boost::prior;
which header file include next_prio
Lars Gullik BjÃnnes wrote:
> Can we begin by just applying the PosIterator files?
> (makes further patches easier to digest)
Ok, first step. Can I apply this?
Alfredo
Index: Makefile.am
===
RCS file: /usr/local/lyx/cvsroot/lyx-deve
Kornel Benko wrote:
> Undo. I expected the box to disappear. And it is current cvs as of 13:00
> today + search3.diff
It is already in current cvs (i.e. not related to search3.diff).
Alfredo
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 1. November 2003 22:12, Alfredo Braunstein wrote:
> Kornel Benko wrote:
>
> > 1.) Select a paragraph
> > 2.) Insert->box->framed
> > 3.) collapse it
> > 4.) position cursor before it
> > 5.) search
> >
> > BTW, I cannot reproduce it anymore.
>
> Ne
Kornel Benko wrote:
> 1.) Select a paragraph
> 2.) Insert->box->framed
> 3.) collapse it
> 4.) position cursor before it
> 5.) search
>
> BTW, I cannot reproduce it anymore.
Neither do I. Let's hope it forgot ;-)
>> > 5.) undo on this freshly created box crashed lyx
>>
>> Is it related to s
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 1. November 2003 21:10, Alfredo Braunstein wrote:
> Kornel Benko wrote:
>
> > 6.) Find text in collapsed ERT --> cursor moves there, but it stays
> > collapsed
>
> I see it.
>
> > 7.) could not find text in collapsed box
>
> A collapsed minipa
Kornel Benko wrote:
> 6.) Find text in collapsed ERT --> cursor moves there, but it stays
> collapsed
I see it.
> 7.) could not find text in collapsed box
A collapsed minipage? I cannot reproduce for some reason; can you give more
precise instruccions?
> 5.) undo on this freshly created
Lars Gullik BjÃnnes wrote:
> Can we begin by just applying the PosIterator files?
> (makes further patches easier to digest)
I need this lockPath to make all the locking dirty work, and will die with
the locking stuff.
Would an ugly change like this to iterators.[Ch] be accepted? (including
PosI
Kornel Benko wrote:
> I cannot detect any. It's superb.
> Different feeeling to that I have using emacs.
> (Undo of replace_all is undo_all. Hmmm, I decide, I like it that way)
;-) I also like it.
> 1.) Ok now,
> 4.) Ok now,
Cool.
> 6.) Find text in collapsed ERT --> cursor moves there,
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 1. November 2003 18:47, Lars Gullik Bjønnes wrote:
> Alfredo Braunstein <[EMAIL PROTECTED]> writes:
>
> | Alfredo Braunstein wrote:
> >
> >> Kornel Benko wrote:
> >>
> >>> 1.)Replace all, then try undo --> command disabled, nothing happens
> >>
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 1. November 2003 17:49, Alfredo Braunstein wrote:
> Alfredo Braunstein wrote:
>
> > Kornel Benko wrote:
> >
> >> 1.)Replace all, then try undo --> command disabled, nothing happens
> >> --> not so good
> >> 2.) Super fast
> >> 3.) If st
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| Alfredo Braunstein wrote:
>
>> Kornel Benko wrote:
>>
>>> 1.)Replace all, then try undo --> command disabled, nothing happens
>>> --> not so good
>>> 2.) Super fast
>>> 3.) If string not found, cursor is not going to the end of documen
Alfredo Braunstein wrote:
> Kornel Benko wrote:
>
>> 1.)Replace all, then try undo --> command disabled, nothing happens
>> --> not so good
>> 2.) Super fast
>> 3.) If string not found, cursor is not going to the end of document
>> --> wonderfull
>> 4.) Language of replaced strin
Alfredo Braunstein wrote:
> > That's great. Do you plan to let the spellchecker also benefit from this
> > eventually? (sorry, I didn't really follow the discussions this week).
>
> Possibly. Will have a look at it. But I'll wait for a revision of the patch
> first, I have to know that the overall
Juergen Spitzmueller wrote:
> Alfredo Braunstein wrote:
>> and fixes lyxfind.C with it:
>
> That's great. Do you plan to let the spellchecker also benefit from this
> eventually? (sorry, I didn't really follow the discussions this week).
Possibly. Will have a look at it. But I'll wait for a revi
Alfredo Braunstein wrote:
> and fixes lyxfind.C with it:
That's great. Do you plan to let the spellchecker also benefit from this
eventually? (sorry, I didn't really follow the discussions this week).
JÃrgen.
Kornel Benko wrote:
> 1.)Replace all, then try undo --> command disabled, nothing happens --> not so
> good
> 2.) Super fast
> 3.) If string not found, cursor is not going to the end of document -->
> wonderfull
> 4.) Language of replaced string is changed to the language of doc
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 1. November 2003 14:40, Kornel Benko wrote:
> On Samstag, 1. November 2003 13:26, Alfredo Braunstein wrote:
> > Alfredo Braunstein wrote:
> >
> > Updated version.
> >
> > - Introduces PosIterator.[Ch]
> >
> > and fixes lyxfind.C with it:
> >
> > - Thi
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 1. November 2003 13:26, Alfredo Braunstein wrote:
> Alfredo Braunstein wrote:
>
> Updated version.
>
> - Introduces PosIterator.[Ch]
>
> and fixes lyxfind.C with it:
>
> - This has no S&R regressions wrt. 1.3.x I am aware of
> - allows backward re
Alfredo Braunstein wrote:
Updated version.
- Introduces PosIterator.[Ch]
and fixes lyxfind.C with it:
- This has no S&R regressions wrt. 1.3.x I am aware of
- allows backward replaces (didn't work in 1.3.x)
- fixes the "search ignoring things in tables" bug 576.
- "replace all" is faster and
Not tested througly, but seems to work normally on standard operations.
(note that almost all the + are in the new files...)
Comments please?
BufferView_pimpl.C|2
Makefile.am |2
PosIterator.C | 151 ++
PosIterator.h | 66 +
52 matches
Mail list logo
