Re: [patch] lyxlib.C

2003-10-08 Thread Andre Poenitz
On Wed, Oct 08, 2003 at 12:56:58PM +0200, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | I've mentioned this before. The attached file bundles the contents of > | these files into one, making it simple to find the function declared > | in lyxlib.h and removing clutt

Re: [patch] lyxlib.C

2003-10-08 Thread Angus Leeming
John Levon wrote: >> Than why 'I agree with Angus.' ? > > Because the .C file is a different matter, it does not cause > significant false dependencies since nobody #includes C and link > time is not much of an issue Actually, my design strategy was each .h file should have a corresponding .C

Re: [patch] lyxlib.C

2003-10-08 Thread John Levon
On Wed, Oct 08, 2003 at 01:53:05PM +, Angus Leeming wrote: > Than why 'I agree with Angus.' ? Because the .C file is a different matter, it does not cause significant false dependencies since nobody #includes C and link time is not much of an issue regards john -- Khendon's Law: If the s

Re: [patch] lyxlib.C

2003-10-08 Thread Angus Leeming
John Levon wrote: > On Wed, Oct 08, 2003 at 02:31:08PM +0200, Lars Gullik Bj?nnes wrote: > >> You want to split the header file? > > Yup Than why 'I agree with Angus.' ? Anyway, I'll hold off on committing lyxlib.C... -- Angus

Re: [patch] lyxlib.C

2003-10-08 Thread John Levon
On Wed, Oct 08, 2003 at 02:31:08PM +0200, Lars Gullik Bj?nnes wrote: > You want to split the header file? Yup john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.

Re: [patch] lyxlib.C

2003-10-08 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Oct 08, 2003 at 12:56:58PM +0200, Lars Gullik Bj?nnes wrote: > >> You add clutter to a file instead of the dir. why? > | I agree with Angus. It's more important that we have separate ehader | files than the .C You want to split the header file?

Re: [patch] lyxlib.C

2003-10-08 Thread John Levon
On Wed, Oct 08, 2003 at 12:56:58PM +0200, Lars Gullik Bj?nnes wrote: > You add clutter to a file instead of the dir. why? I agree with Angus. It's more important that we have separate ehader files than the .C john -- Khendon's Law: If the same point is made twice by the same person, the thre

Re: [patch] lyxlib.C

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | All proposals that go against some idea/plan/whatever I have had >> | once upon a time should be thrown away. >> >> Especially if you don't look at my counter patch. > | Nice pun. Even if not meant ;-P Hmm... I didn't ge

Re: [patch] lyxlib.C

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | All proposals that go against some idea/plan/whatever I have had > | once upon a time should be thrown away. > > Especially if you don't look at my counter patch. Nice pun. Even if not meant ;-P -- Angus

Re: [patch] lyxlib.C

2003-10-08 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Angus Leeming <[EMAIL PROTECTED]> writes: > | | Angus Leeming wrote: >> >>> I would argue that 207 lines is not 'clutter' but that 11 files is. >>> Indeed, I even save 140 lines of source if you talk about clutter. >> | | Make that 'save 164 lines

Re: [patch] lyxlib.C

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Angus Leeming wrote: > >> I would argue that 207 lines is not 'clutter' but that 11 files is. >> Indeed, I even save 140 lines of source if you talk about clutter. > | Make that 'save 164 lines of source'. I forgot mkdir.C. > | Anyway, I asked specifical

Re: [patch] lyxlib.C

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | Any objections to me committing this? >> >> You add clutter to a file instead of the dir. why? >> why why why!!! > | I would argue that 207 lines is not 'clutter' but that 11 files is. clut clut clutter! | Indeed, I ev

Re: [patch] lyxlib.C

2003-10-08 Thread Angus Leeming
Angus Leeming wrote: > I would argue that 207 lines is not 'clutter' but that 11 files is. > Indeed, I even save 140 lines of source if you talk about clutter. Make that 'save 164 lines of source'. I forgot mkdir.C. Anyway, I asked specifically because I wanted to guage people's opinions about

Re: [patch] lyxlib.C

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | Any objections to me committing this? > > You add clutter to a file instead of the dir. why? > why why why!!! I would argue that 207 lines is not 'clutter' but that 11 files is. Indeed, I even save 140 lines of source if you talk about clutter. Angus Currently: $

Re: [patch] lyxlib.C

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | I've mentioned this before. The attached file bundles the contents of | these files into one, making it simple to find the function declared | in lyxlib.h and removing clutter from the support dir. > | abort.C chdir.C getcwd.C putenv.C rmdir.C

[patch] lyxlib.C

2003-10-08 Thread Angus Leeming
I've mentioned this before. The attached file bundles the contents of these files into one, making it simple to find the function declared in lyxlib.h and removing clutter from the support dir. abort.C chdir.C getcwd.C putenv.C rmdir.C unlink.C atoi.C copy.C kill.Crename.C tempn