Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-19 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > What is the enchant situation wrt this? Judging from the enchant patch we received, enchant has support for ignore all (add_to_session) and personal dictionaries (add_to_pwl, which is BTW wrong in the proposed patch) Jürgen [1] http://www.lyx.org/trac/attachment/t

Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-19 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: > In this case we should not use aspell 'ignore' nor 'add' feature either. We probably need 'add for document' and 'add permanently' (or whatever). What is the enchant situation wrt this? JMarc

Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-19 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > > Note that this is an occasion for having a per-document ignore list. > > > > In this case we should not use aspell 'ignore' nor 'add' feature either. I'm not sure. I think a per-document ignore list is a nice addition, but no replacement for either a global "add

Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-19 Thread Abdelrazak Younes
On 01/19/2010 09:51 AM, Jean-Marc Lasgouttes wrote: Jürgen Spitzmüller writes: rgheck wrote: FYI, the accept() function isn't implemented in HunspellChecker, and so far as I can see this is because Hunspell itself does not provide a suitable method. I cannot believe hunspell

Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-19 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > rgheck wrote: >> FYI, the accept() function isn't implemented in HunspellChecker, and so >> far as I can see this is because Hunspell itself does not provide a >> suitable method. > > I cannot believe hunspell is missing such a fundamental function. > But in fact thi

Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-19 Thread Abdelrazak Younes
On 01/18/2010 10:10 PM, rgheck wrote: On 01/18/2010 01:37 PM, Jürgen Spitzmüller wrote: Abdel, this is for you. The main purpose of these lfuns is the addition of two items to the continuous spellchecking context menu, namely "Ignore All" and "Add to personal dictionary". These are pretty fun

Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-19 Thread Abdelrazak Younes
On 01/18/2010 07:37 PM, Jürgen Spitzmüller wrote: Abdel, this is for you. The main purpose of these lfuns is the addition of two items to the continuous spellchecking context menu, namely "Ignore All" and "Add to personal dictionary". These are pretty fundamental for a proper continuous spell ch

Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-19 Thread Jürgen Spitzmüller
rgheck wrote: > FYI, the accept() function isn't implemented in HunspellChecker, and so > far as I can see this is because Hunspell itself does not provide a > suitable method. I cannot believe hunspell is missing such a fundamental function. But in fact this seems to be the case. OOo manages it

Re: [patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-18 Thread rgheck
On 01/18/2010 01:37 PM, Jürgen Spitzmüller wrote: Abdel, this is for you. The main purpose of these lfuns is the addition of two items to the continuous spellchecking context menu, namely "Ignore All" and "Add to personal dictionary". These are pretty fundamental for a proper continuous spell ch

[patch] implement LFUN_SPELLING_ADD and LFUN_SPELLING_IGNORE

2010-01-18 Thread Jürgen Spitzmüller
Abdel, this is for you. The main purpose of these lfuns is the addition of two items to the continuous spellchecking context menu, namely "Ignore All" and "Add to personal dictionary". These are pretty fundamental for a proper continuous spell checking framework, IMHO. Jürgen Index: src/LyXAct