Re: [patch] hide RowPainter

2003-07-14 Thread Andre Poenitz
On Mon, Jul 14, 2003 at 06:40:10PM +0100, John Levon wrote: > > Note that the current split in 'constructor' and function call > > is rather arbitrary. > > I know ... most of the state is ugly crap anyway though... As long as it is as self-cointained as it is right now there is not too much to wo

Re: [patch] hide RowPainter

2003-07-14 Thread John Levon
On Mon, Jul 14, 2003 at 07:39:51PM +0200, Andre Poenitz wrote: > > Suppose so. I don't like so many parameters though, > > Note that the current split in 'constructor' and function call > is rather arbitrary. I know ... most of the state is ugly crap anyway though... > Ok. 'paintRows' perhaps?

Re: [patch] hide RowPainter

2003-07-14 Thread Andre Poenitz
On Mon, Jul 14, 2003 at 06:32:58PM +0100, John Levon wrote: > On Mon, Jul 14, 2003 at 07:03:05PM +0200, Andre Poenitz wrote: > > > I thought it could be moved behind a single > > > > void paint(BufferView const & bv, LyXText const & text, > > RowList::iterator rit, int y_offset, int x_offse

Re: [patch] hide RowPainter

2003-07-14 Thread John Levon
On Mon, Jul 14, 2003 at 07:03:05PM +0200, Andre Poenitz wrote: > I thought it could be moved behind a single > > void paint(BufferView const & bv, LyXText const & text, > RowList::iterator rit, int y_offset, int x_offset, int y) Suppose so. I don't like so many parameters though, and I fin

[patch] hide RowPainter

2003-07-14 Thread Andre Poenitz
As all RowPainter usage follows the mantra RowPainter painter(bv, text, rit); painter.paint(y_offset, x_offset, y); I thought it could be moved behind a single void paint(BufferView const & bv, LyXText const & text, RowList::iterator rit, int y_offset, int x_offset, int y)