Re: [patch] fix longtable bug 6057

2009-07-11 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > I understand. So your patch is the right solution. I'm gonna revert my > patch in trunk so that you can apply your patch. Thanks. I'll do that later. Jürgen

Re: [patch] fix longtable bug 6057

2009-07-11 Thread Uwe Stöhr
>> then we need to set the checkbox for the >> first header when adding a caption. > > But that generates different output: > > \caption[Example Phone List]{Example Phone List\label{tab:DiffCaptions}} > \endfirsthead > vs. > \caption[Example Phone List]{Example Phone List\label{tab:DiffCaptions}}

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > Why this? The first header is not empty. The first header is the caption. > > That's confusing: The table dialog states that the first header is not > empty, so the user might look for the row of the first header but cannot > find it. > When the first header is really the capti

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Uwe Stöhr
> Why this? The first header is not empty. The first header is the caption. That's confusing: The table dialog states that the first header is not empty, so the user might look for the row of the first header but cannot find it. When the first header is really the caption (probably the longtable

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > As far as I can see, the real fix would be to assure that the caption row > > > is terminated by an \endfirsthead, not by a \tabularnewline, if no first > > header is used. > > That is correct, but that is the same as if you set the first header to be > empty. With your patch

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Uwe Stöhr
> As far as I can see, the real fix would be to assure that the caption row > is terminated by an \endfirsthead, not by a \tabularnewline, if no first > header is used. That is correct, but that is the same as if you set the first header to be empty. With your patch the bug is also fixed, but th

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Jürgen Spitzmüller wrote: > > In any case, I'd like to understand the actual problem first. > > As far as I can see, the real fix would be to assure that the caption row > is terminated by an \endfirsthead, not by a \tabularnewline, if no first > header is used. The att

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > In any case, I'd like to understand the actual problem first. As far as I can see, the real fix would be to assure that the caption row is terminated by an \endfirsthead, not by a \tabularnewline, if no first header is used. However, what if the user wants, for whate

Re: [patch] fix longtable bug 6057

2009-07-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > I'm very surprised about this. The longtable doc does not mention that > > \endhead needs a prior \endfirsthead. > > It is the opposite way: \endfirsthead has to be before \endhead That's exactly what I wrote. > > I see why the problem occurs, but I think the fix is too ge

Re: [patch] fix longtable bug 6057

2009-07-09 Thread Uwe Stöhr
>> expects in every table >> \endfirsthead >> before >> \endhead . > > I'm very surprised about this. The longtable doc does not mention that > \endhead needs a prior \endfirsthead. It is the opposite way: \endfirsthead has to be before \endhead > I see why the problem occurs, but I think the fi

Re: [patch] fix longtable bug 6057

2009-07-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > The attached patch fixes bug http://www.lyx.org/trac/ticket/6057 that LyX > allows having header rows in a longtable without having a first header row. > This bug leads to wrong TOC entries for longtables because longtable > expects in every table > \endfirsthead > before > \endh

Re: [patch] fix longtable bug 6057

2009-07-09 Thread Uwe Stöhr
Uwe Stöhr schrieb: The attached patch fixes bug http://www.lyx.org/trac/ticket/6057 that LyX allows having header rows in a longtable without having a first header row. This bug leads to wrong TOC entries for longtables because longtable expects in every table \endfirsthead before \endhead .

[patch] fix longtable bug 6057

2009-07-07 Thread Uwe Stöhr
The attached patch fixes bug http://www.lyx.org/trac/ticket/6057 that LyX allows having header rows in a longtable without having a first header row. This bug leads to wrong TOC entries for longtables because longtable expects in every table \endfirsthead before \endhead . Any objections? If no