Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-18 Thread Abdelrazak Younes
Uwe Stöhr wrote: > OK, if the above change fix the crash, just put this updated patch in, I think we already > discussed enough this one ;-) Yes, this was the reason. I committed the patch. But you did not correct the other cases of (size - 1) use. I'll correct that plus some style issues.

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-17 Thread Uwe Stöhr
> OK, if the above change fix the crash, just put this updated patch in, I think we already > discussed enough this one ;-) Yes, this was the reason. I committed the patch. regards Uwe

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-17 Thread Abdelrazak Younes
Uwe Stöhr wrote: Ich schrieb: >>OK, I'll provide an improved version of my patch that also shows the code for \big etc. > > Hum... then why not just take my patch? because you display LFUNS ;-). Just joking. Your patch is good as it cleans up the whole code. I take it and built in w

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-16 Thread Uwe Stöhr
Ich schrieb: >>OK, I'll provide an improved version of my patch that also shows the code for \big etc. > > Hum... then why not just take my patch? because you display LFUNS ;-). Just joking. Your patch is good as it cleans up the whole code. I take it and built in what I like to have

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-16 Thread Uwe Stöhr
> Well, The fact that not many users do not know about LFUNs does not mean that they should not > know. I at least am glad to know what LyX is really doing. For example, all the LFUN lanched via > the menu are displayed in the status bar. And you know that we have a mini-buffer that is useful >

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-16 Thread Abdelrazak Younes
Uwe Stöhr wrote: > Note that my patch shows the LFUN argument not the LateX code, so it won't show the \left and > \right. For example it will show: > > { } > { Vert > bigl \{ bigr \Vert > > I think it is useful to teach the user about the LFUNs. So it is not strictly about LateX; I >

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-16 Thread Uwe Stöhr
> Note that my patch shows the LFUN argument not the LateX code, so it won't show the \left and > \right. For example it will show: > > { } > { Vert > bigl \{ bigr \Vert > > I think it is useful to teach the user about the LFUNs. So it is not strictly about LateX; I > should probably rename the

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-16 Thread Abdelrazak Younes
Uwe Stöhr wrote: >>Your patch doesn't fix the bugs and it gives out e.g. "\{\}" (always both commands). > Yes, that's the point. They will see all options at the same time before pressing "Insert". You > think the user needs a SMALL info, I think otherwise that the user should need the

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-16 Thread Uwe Stöhr
>>Your patch doesn't fix the bugs and it gives out e.g. "\{\}" (always both commands). > Yes, that's the point. They will see all options at the same time before pressing "Insert". You > think the user needs a SMALL info, I think otherwise that the user should need the full info. The > sma

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-16 Thread Abdelrazak Younes
Uwe Stöhr wrote: > That won't work with big delimiters. Besides, that's not what I was talking about, I meant to > display the full LFUN argument. Fro what is this needed? The users needs a SMALL info, so just giving out e.g. "\bigg\{" should be enough. Even \right and \left is in my opinio

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-15 Thread Uwe Stöhr
> That won't work with big delimiters. Besides, that's not what I was talking about, I meant to > display the full LFUN argument. Fro what is this needed? The users needs a SMALL info, so just giving out e.g. "\bigg\{" should be enough. Even \right and \left is in my opinion not needed because

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-15 Thread Andre Poenitz
On Sat, Apr 14, 2007 at 08:35:33PM +0200, Uwe Stöhr wrote: > Index: frontends/qt4/QDelimiterDialog.C > === > --- frontends/qt4/QDelimiterDialog.C (revision 17811) > +++ frontends/qt4/QDelimiterDialog.C (working copy) > @@ -172,16 +17

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-15 Thread Abdelrazak Younes
Uwe Stöhr wrote: > Please hold on. I propose instead to display the full TeX code in any case as discussed in > bugzilla. I'll work on a patch. I can't hold it, because this is so simple with the new infrastructure of my patch, here it is again - with displaying "\right" and "\left". That

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-15 Thread Uwe Stöhr
> Please hold on. I propose instead to display the full TeX code in any case as discussed in > bugzilla. I'll work on a patch. I can't hold it, because this is so simple with the new infrastructure of my patch, here it is again - with displaying "\right" and "\left". Abdel. Index: frontends/

Re: [patch] fix delimiter bug 3456 and bug 3457

2007-04-15 Thread Abdelrazak Younes
Uwe Stöhr wrote: The attached patch fixes - TeX-code not updated when switchin on the same item row to the opposite character (bug 3456) by adding a method that handles the on_click. - TeX-code incorrectly displayed because the "\" character was set to all delimiters, also to e.g."[" as

[patch] fix delimiter bug 3456 and bug 3457

2007-04-14 Thread Uwe Stöhr
The attached patch fixes - TeX-code not updated when switchin on the same item row to the opposite character (bug 3456) by adding a method that handles the on_click. - TeX-code incorrectly displayed because the "\" character was set to all delimiters, also to e.g."[" as "\[" (bug 3457) -