Re: [patch] fix crash in tabulars

2006-06-26 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> OK. I just committed to branch. Trunk will follow, as soon as Juergen> it finished compiling. I guess this does not need mentioning Juergen> in status.14x, since the bug has been introduced after 1.4.1? It seems that I r

Re: [patch] fix crash in tabulars

2006-06-26 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > The code looks OK, and I tested that it fixes the bug. It may be > better to rewrite it as a switch, though. Later. > This can be applied to 1.4 and 1.5. OK. I just committed to branch. Trunk will follow, as soon as it finished compiling. I guess this does not need

Re: [patch] fix crash in tabulars

2006-06-26 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: >> Why is the code for mouse1 useful? Juergen> Because it does exactly what we want in that case. We want to Juergen> set the cursor before opening the dialog (i.e. we set the Juergen> cursor on press and open the dialog on relea

Re: [patch] fix crash in tabulars

2006-06-26 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Juergen> OK for branch and trunk? > > Could you explain what was wrong exactly? My theory is: When the tabular was marked, the cursor has become invalid when right-clicking, then LyX asserted. I guess my code for setting the cursor on right-clicking (in order to fix

Re: [patch] fix crash in tabulars

2006-06-26 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> The attached patch fixes the crash described here: Juergen> http://marc.theaimsgroup.com/?l=lyx-devel&m=115107305725444&w=2 Juergen> OK for branch and trunk? Could you explain what was wrong exactly? Why is the code for

[patch] fix crash in tabulars

2006-06-26 Thread Juergen Spitzmueller
The attached patch fixes the crash described here: http://marc.theaimsgroup.com/?l=lyx-devel&m=115107305725444&w=2 OK for branch and trunk? Jürgen Index: src/insets/insettabular.C === --- src/insets/insettabular.C (Revision 14187) ++