> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:
Uwe> I hope I haven't forgotten something this time.
No you did not. Thanks for your patience :)
JMarc
Jean-Marc Lasgouttes schrieb:
Your solution relies about compile time constants, while the one I
proposed does take in account lyxrc settings instead. Please commit
this one (although I think that in practice it will not be noticed by
users :)
Done, and as you wrote earlier in this thread also
> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:
>> I know that this lyxrc setting to choose spell lib is stupid, but
>> we have to live with it for now, I think.
Uwe> I don't understand. What is the advantage to my solution? I
Uwe> thought the file filter should be according to what the user
>>> What about something like
>>>
>>> +if (lyxrc.use_spell_lib)
>>> +return browseFile(file,
>>> + _("Choose personal dictionary"),
>>> + FileFilterList(_("*.pws")));
>>> +else
>>> +return browseFile(file,
>>
Jean-Marc Lasgouttes wrote:
>> "Georg" == Georg Baum
>> <[EMAIL PROTECTED]>
>> writes:
> Georg> Dropping pspell would not help. We do not really distinguish
> Georg> pspell/aspell, so only dropping both would make a difference.
>
> But what suffix do they use for word lists?
.en.pws,
Jean-Marc Lasgouttes schrieb:
What about something like
+ if (lyxrc.use_spell_lib)
+ return browseFile(file,
+ _("Choose personal dictionary"),
+ FileFilterList(_("*.pws")));
+ else
+ return
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
>> Could we at least drop pspell support in 1.5? This will enable to
>> get rid of these macro altogether.
Georg> Dropping pspell would not help. We do not really distinguish
Georg> pspell/aspell, so only dropping both would make a differenc
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes wrote:
>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>>
Abdelrazak> Wait a minute, this use_spell_lib is about aspell/pspell
Abdelrazak> not about ispell.
>> it is about us
Abdelrazak Younes wrote:
> Jean-Marc Lasgouttes wrote:
>>> "Abdelrazak" == Abdelrazak Younes
>>> <[EMAIL PROTECTED]> writes:
>>
>> Abdelrazak> Wait a minute, this use_spell_lib is about aspell/pspell
>> Abdelrazak> not about ispell.
>>
>> it is about using a library (aspell or pspell) ve
Georg Baum wrote:
Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
What about something like
+if (lyxrc.use_spell_lib)
+return browseFile(file,
+ _("Choose personal dictionary"),
+ FileFilterList(_("*.pws")));
+
Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Wait a minute, this use_spell_lib is about aspell/pspell
Abdelrazak> not about ispell.
it is about using a library (aspell or pspell) versus a program
(ispell).
pspell is a program AFAIK.
Abdelrazak Younes wrote:
> Jean-Marc Lasgouttes wrote:
>> What about something like
>>
>> +if (lyxrc.use_spell_lib)
>> +return browseFile(file,
>> + _("Choose personal dictionary"),
>> + FileFilterList(_("*.pws")));
>> +
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Wait a minute, this use_spell_lib is about aspell/pspell
Abdelrazak> not about ispell.
it is about using a library (aspell or pspell) versus a program
(ispell). Or course, if the program is "aspell", we should use a
Jean-Marc Lasgouttes wrote:
"Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:
Uwe> Jean-Marc Lasgouttes schrieb: that only *.ispell is used as file
Uwe> filter when ispell is set in the preferences and *.pws only when
Uwe> aspell ist set? If yes I can have a look.
Yes, something like that. Thank
Jean-Marc Lasgouttes wrote:
"Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:
Uwe> Jean-Marc Lasgouttes schrieb: that only *.ispell is used as file
Uwe> filter when ispell is set in the preferences and *.pws only when
Uwe> aspell ist set? If yes I can have a look.
Yes, something like that. Thank
> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:
Uwe> Jean-Marc Lasgouttes schrieb: that only *.ispell is used as file
Uwe> filter when ispell is set in the preferences and *.pws only when
Uwe> aspell ist set? If yes I can have a look.
>> Yes, something like that. Thanks.
Uwe> Is the attache
Uwe Stöhr wrote:
Jean-Marc Lasgouttes schrieb:
Uwe> that only *.ispell is used
Uwe> as file filter when ispell is set in the preferences and *.pws
Uwe> only when aspell ist set? If yes I can have a look.
Yes, something like that. Thanks.
Is the attached OK?
In principle No, this is not OK:
Jean-Marc Lasgouttes schrieb:
Uwe> that only *.ispell is used
Uwe> as file filter when ispell is set in the preferences and *.pws
Uwe> only when aspell ist set? If yes I can have a look.
Yes, something like that. Thanks.
Is the attached OK?
regards Uwe
Index: ControlPrefs.C
=
> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:
Uwe> Jean-Marc Lasgouttes schrieb:
>> Would it be difficult to use the extension which is coherent with
>> the current dictionary setting (either aspell or ispell files)?
Uwe> I don't understand. What do you mean, that only *.ispell is used
Uwe
Jean-Marc Lasgouttes schrieb:
Would it be difficult to use the extension which is coherent with the
current dictionary setting (either aspell or ispell files)?
I don't understand. What do you mean, that only *.ispell is used as file filter when ispell is set
in the preferences and *.pws only
> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:
Uwe> As I understood the bug report, only a file filter for aspell
Uwe> dictionaries is missing. The attached trivial patch fixes this.
Would it be difficult to use the extension which is coherent with the
current dictionary setting (either asp
As I understood the bug report, only a file filter for aspell dictionaries is
missing.
The attached trivial patch fixes this.
JMarc, also for 1.4.x?
regards Uwe
Index: ControlPrefs.C
===
--- ControlPrefs.C (revision 16895)
+++ Con
22 matches
Mail list logo
