Re: [patch] fix bug 4625

2009-01-11 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: +Preamble +\...@ifundefined{textcolor}{} +{% + \definecolor{BLACK}{gray}{0} + \definecolor{WHITE}{gray}{1} Why not \...@ifundefined{definecolor}{} ? That is equivalent to my solution. When \textcolor is known, also \definecolor is known. regard

Re: [patch] fix bug 4625

2009-01-11 Thread Jean-Marc Lasgouttes
+Preamble + \...@ifundefined{textcolor}{} + {% +\definecolor{BLACK}{gray}{0} +\definecolor{WHITE}{gray}{1} Why not \...@ifundefined{definecolor}{} ? JMarc

Re: [patch] fix bug 4625 - request to remove the old revtex.layout for LyX 2.0

2009-01-11 Thread Uwe Stöhr
>> Or should I apply the fix >> nevertheless also to this file?" > > I think it's not needed. The patch is in. >> Btw. as the old revtex package is from 1992 and is incompatible to recent >> babel versions, I propose to remove this layout for LyX 2.0. Opinions? > > I would leave things as they a

Re: [patch] fix bug 4625 - request to remove the old revtex.layout for LyX 2.0

2009-01-11 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > What about my question: > "The same is needed for the old revtex.layout but I think we shouldn't take > of this file anymore because the underlying LaTeX package is outdated since > 1995 and incompatible to recent babel versions. Or should I apply the fix > nevertheless also to t

Re: [patch] fix bug 4625 - request to remove the old revtex.layout for LyX 2.0

2009-01-11 Thread Uwe Stöhr
> OK. What about my question: "The same is needed for the old revtex.layout but I think we shouldn't take of this file anymore because the underlying LaTeX package is outdated since 1995 and incompatible to recent babel versions. Or should I apply the fix nevertheless also to this file?" Btw.

Re: [patch] fix bug 4625

2009-01-11 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > Oops, the attached one works. OK. Jürgen

Re: [patch] fix bug 4625

2009-01-11 Thread Uwe Stöhr
> This does not work. If xou do not use colors, you get > > ! Undefined control sequence. > l.10 \definecolor Oops, the attached one works. regards Uwe Index: revtex4.layout === --- revtex4.layout (revision 28092) +++ revtex4.layout

Re: [patch] fix bug 4625

2009-01-10 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > The attached patch fixes http://bugzilla.lyx.org/show_bug.cgi?id=4625 by > defining RevTeX's uppercase color names in the layout name. OK for branch > too? This does not work. If xou do not use colors, you get ! Undefined control sequence. l.10 \definecolor {BL

Re: [patch] fix bug 4625

2009-01-10 Thread Uwe Stöhr
Uwe Stöhr schrieb: The attached patch fixes http://bugzilla.lyx.org/show_bug.cgi?id=4625 by defining RevTeX's uppercase color names in the layout name. The same is needed for the old revtex.layout but I think we shouldn't take of this file anymore because the underlying LaTeX package is outdat

[patch] fix bug 4625

2009-01-10 Thread Uwe Stöhr
The attached patch fixes http://bugzilla.lyx.org/show_bug.cgi?id=4625 by defining RevTeX's uppercase color names in the layout name. OK for branch too? regards Uwe Index: revtex4.layout === --- revtex4.layout (revision 28082) +++ re