Coding style guidelines (was: [patch] fix bug 3569)

2007-05-09 Thread christian . ridderstrom
On Wed, 9 May 2007, Andre Poenitz wrote: On Wed, May 09, 2007 at 02:00:00AM +0200, Uwe Stöhr wrote: Reduce the line length of the comments, i.e.: You asked me about reasons for the line length a while back. One trivial reason is that your diff is diff(icult:-) to read in my mail program...

Re: [patch] fix bug 3569

2007-05-08 Thread Andre Poenitz
On Wed, May 09, 2007 at 02:00:00AM +0200, Uwe Stöhr wrote: > > Reduce the line length of the comments, i.e.: > > > > You asked me about reasons for the line length a while back. One trivial > reason is that your diff > > is diff(icult:-) to read in my mail program... > > The common line length is

Re: [patch] fix bug 3569

2007-05-08 Thread Uwe Stöhr
> Reduce the line length of the comments, i.e.: > > You asked me about reasons for the line length a while back. One trivial reason is that your diff > is diff(icult:-) to read in my mail program... The common line length is 80 characters per line I read somewhere. But when you look at BufferPa

Re: [patch] fix bug 3569

2007-05-08 Thread Uwe Stöhr
Andre Poenitz schrieb: + if (lang_opts != "") if (!lang_opts.empty()) Thanks, I've put it in now with this syntax: http://www.lyx.org/trac/changeset/18238 thanks and regards Uwe

Re: [patch] fix bug 3569

2007-05-08 Thread christian . ridderstrom
On Tue, 8 May 2007, Uwe Stöhr wrote: Uwe Stöhr schrieb: Attached is a better patch. I now also implement Abdel's annotations. Can this one now go in? Reduce the line length of the comments, i.e.: + language->babel().empty() ) { + // if the armscii8 or a CJK en

Re: [patch] fix bug 3569

2007-05-08 Thread Andre Poenitz
On Tue, May 08, 2007 at 08:46:15PM +0200, Uwe Stöhr wrote: > Uwe Stöhr schrieb: > > >Attached is a better patch. > > I now also implement Abdel's annotations. Can this one now go in? > > regards Uwe > Index: BufferParams.cpp > ===

Re: [patch] fix bug 3569

2007-05-08 Thread Abdelrazak Younes
Uwe Stöhr wrote: + // if the armscii8 or a CJK encoding is used, babel has to be called for + // foreign languages + if (lang_opts != "") + if (!lang_opts.empty()) + tmp = string("\\usepackage[") + lang_opts + "]{b

Re: [patch] fix bug 3569

2007-05-08 Thread Uwe Stöhr
Uwe Stöhr schrieb: Attached is a better patch. I now also implement Abdel's annotations. Can this one now go in? regards Uwe Index: BufferParams.cpp === --- BufferParams.cpp (revision 18237) +++ BufferParams.cpp (working copy) @@

Re: [patch] fix bug 3569

2007-05-07 Thread Uwe Stöhr
Uwe Stöhr schrieb: Attached is the patch that fixes the problem, that babel isn't called when you have foreign languages in CJK and Armenian-documents. Attached is a better patch. I think this is now the last remaining babel bug. Unfortunately I also found this one: http://bugzilla.lyx.or