Re: [patch] fix bug 2789

2006-09-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> There was a thinko in the patch. Can you please try this one? Georg> It works for me, but I do not understand why it worked without Georg> the

Re: [patch] fix bug 2789

2006-09-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Am Samstag, 9. September 2006 20:07 schrieb Bo Peng: >> > Please test. >> >> I do not know what is going on, but after I apply your patch, >> >> 1. open a new document 2. insert displayed math, type in dd, insert >> label, >> >> the

Re: [patch] fix bug 2789

2006-09-26 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > Georg> There was a thinko in the patch. Can you please try this one? > Georg> It works for me, but I do not understand why it worked without > Georg> the patch, since the culprit was a break instea

Re: [patch] fix bug 2789

2006-09-25 Thread Georg Baum
Am Samstag, 9. September 2006 20:07 schrieb Bo Peng: > > Please test. > > I do not know what is going on, but after I apply your patch, > > 1. open a new document > 2. insert displayed math, type in dd, insert label, > > the dialog can not get focus. I revert your patch and things go back > to n

Re: [patch] fix bug 2789

2006-09-11 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > The problem is that this text is done in lyxfunc::dispatch only, so it > is possible to bypass the checks by calling directly the wrong > dispatch command. For example, the workaread calls (called?) directly > BufferView::dispatch. > > The extra asserts does not hurt

Re: [patch] fix bug 2789

2006-09-11 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> Just a remark: >> >> case LFUN_INSET_INSERT: { //lyxerr << "arg: " << cmd.argument << >> endl; string const name = cmd.getArg(0); - if (name == "label") { >> >> It would be better to assert on `name ==

Re: [patch] fix bug 2789

2006-09-11 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Just a remark: > > case LFUN_INSET_INSERT: { > //lyxerr << "arg: " << cmd.argument << endl; > string const name = cmd.getArg(0); > - if (name == "label") { > > It would be better to assert on `name == "label"'. Don't you trust the getStatus machinery

Re: [patch] fix bug 2789

2006-09-11 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This patch (for 1.4, but I guess it applies also to trunk) Georg> fixes bug 2789 for me (see Georg> http://bugzilla.lyx.org/show_bug.cgi?id=2789). Georg> Please test. It looks good at least, I'll try to test it. Just a remark:

Re: [patch] fix bug 2789

2006-09-09 Thread Bo Peng
Please test. I do not know what is going on, but after I apply your patch, 1. open a new document 2. insert displayed math, type in dd, insert label, the dialog can not get focus. I revert your patch and things go back to normal. This is under linux, for 1.4.x. Bo

[patch] fix bug 2789

2006-09-08 Thread Georg Baum
This patch (for 1.4, but I guess it applies also to trunk) fixes bug 2789 for me (see http://bugzilla.lyx.org/show_bug.cgi?id=2789). Please test. GeorgIndex: src/mathed/math_hullinset.C === --- src/mathed/math_hullinset.C (Revision