Uwe Stöhr wrote:
> Jürgen, also OK for branch?
OK.
Jürgen
> and even smaller:
Indeed yes. I have put it in:
http://www.lyx.org/trac/changeset/24244
Jürgen, also OK for branch?
thanks Edwin and regards
Uwe
Uwe Stöhr wrote:
Thanks for the hint, this makes the code much smaller.
and even smaller:
string arg = "\\makebox";
if (p.next_token().character() == '(')
//the syntax is: \makebox(x,y)[position]{content}
//the content can be left as is, put the rest in ERT
arg += p.get
Jean-Marc Lasgouttes schrieb:
I think something is wrong here. Arguments in [] are optional. I doubt
that you code will handle \makebox(3,2){contents} gracefully.
You are right, I missed this case.
You should use getFullOpt to read such optional strings (also in the
> other kind of \makebox
Uwe Stöhr <[EMAIL PROTECTED]> writes:
> + else if (t.cs() == "makebox") {
> + if (p.next_token().character() == '(') {
> + //the syntax is:
> \makebox(x,y)[position]{content}
> + //the content can be left as i
i edited the patch a bit and made it a bit nicer by taking handle_ert
out of the if's
i also attach a second version which is much shorter
both untested
Uwe Stöhr wrote:
The attached patch for trunk fixes
http://bugzilla.lyx.org/show_bug.cgi?id=2504
http://bugzilla.lyx.org/show_bug.cgi?id=25
The attached patch for trunk fixes
http://bugzilla.lyx.org/show_bug.cgi?id=2504
http://bugzilla.lyx.org/show_bug.cgi?id=2504#c7
describes what the patch is for.
Jürgen, can this also go into branch?
regards Uwe
Index: text.cpp
===
