Re: [patch] fix bug 2457

2008-04-19 Thread Uwe Stöhr
Andre Poenitz schrieb: What is the benefit of having test files for such very special cases? To build a decent test suite one day. But all cases are also in the manuals. The Math, EmbeddedObjects, and UserGuide manual are excellent test cases. I'll nevertheless add testcases. regards Uwe

Re: [patch] fix bug 2457

2008-04-18 Thread Jean-Marc Lasgouttes
Uwe Stöhr <[EMAIL PROTECTED]> writes: >> Can you add the test file to the repository under, say, tex2lyx/tests? > > I could do this. But should I do this for every tex2lyx patch I send? > What is the benefit of having test files for such very special cases? Note that we already have 2 test files

Re: [patch] fix bug 2457

2008-04-17 Thread Andre Poenitz
On Thu, Apr 17, 2008 at 08:14:08PM +0200, Uwe Stöhr wrote: > > Can you add the test file to the repository under, say, tex2lyx/tests? > > I could do this. But should I do this for every tex2lyx patch I send? What > is the benefit of having test files for such very special cases? To build a decent

Re: [patch] fix bug 2457

2008-04-17 Thread José Matos
On Thursday 17 April 2008 19:14:08 Uwe Stöhr wrote: > > Can you add the test file to the repository under, say, tex2lyx/tests? > > I could do this. But should I do this for every tex2lyx patch I send? What > is the benefit of having test files for such very special cases? > > regards Uwe To guara

Re: [patch] fix bug 2457

2008-04-17 Thread Uwe Stöhr
> Can you add the test file to the repository under, say, tex2lyx/tests? I could do this. But should I do this for every tex2lyx patch I send? What is the benefit of having test files for such very special cases? regards Uwe

Re: [patch] fix bug 2457

2008-04-17 Thread Andre Poenitz
On Thu, Apr 17, 2008 at 02:28:03AM +0200, Uwe Stöhr wrote: > The attached bug adds support for \textcolor to tex2lyx. This fixes > http://bugzilla.lyx.org/show_bug.cgi?id=2457 > > Attached is also a TeX-file as testcase for the patch. Can you add the test file to the repository under, say, tex2ly

Re: [patch] fix bug 2457

2008-04-17 Thread Uwe Stöhr
> Looks good AFAICS (but I did not test it). The patch only works for predefined colors, but not for colors the user have used. I'll investigate a bit deeper. regards Uwe

Re: [patch] fix bug 2457

2008-04-17 Thread Juergen Spitzmueller
Uwe Stöhr wrote: > The attached bug adds support for \textcolor to tex2lyx. This fixes > http://bugzilla.lyx.org/show_bug.cgi?id=2457 Looks good AFAICS (but I did not test it). Jürgen

[patch] fix bug 2457

2008-04-16 Thread Uwe Stöhr
The attached bug adds support for \textcolor to tex2lyx. This fixes http://bugzilla.lyx.org/show_bug.cgi?id=2457 Attached is also a TeX-file as testcase for the patch. regards Uwe Index: text.cpp === --- text.cpp (revision 24310) +