Re: [patch] fix bug 1881

2010-10-09 Thread Richard Heck
On 10/09/2010 12:04 PM, Uwe Stöhr wrote: Am 06.10.2010 04:56, schrieb Richard Heck: Looks fine, as does the other one. I didn't go through that code in detail, but if it's more or less copied from Hyperlink, it should be OK. That said, if it is more or less copied, maybe we should put a rout

Re: [patch] fix bug 1881

2010-10-09 Thread Uwe Stöhr
Am 06.10.2010 04:56, schrieb Richard Heck: Looks fine, as does the other one. I didn't go through that code in detail, but if it's more or less copied from Hyperlink, it should be OK. That said, if it is more or less copied, maybe we should put a routine into lstrings.cpp that will do this?

Re: [patch] fix bug 1881

2010-10-06 Thread Richard Heck
On 10/06/2010 07:55 AM, Uwe Stöhr wrote: That said, if it is more or less copied, maybe we should put a routine into lstrings.cpp that will do this? I considered this but it seems that every inset allows a different set of special characters that needn't to be escape. But you are right that

Re: [patch] fix bug 1881

2010-10-06 Thread Uwe Stöhr
Am 06.10.2010 04:56, schrieb Richard Heck: Looks fine, as does the other one. I didn't go through that code in detail, but if it's more or less copied from Hyperlink, it should be OK. The fix for 1881 is independent of the other patch and doesn't contain code from InsetHyperlink. That said

Re: [patch] fix bug 1881

2010-10-06 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > existing documents. As a user, I would not be pleased if a LyX version > upgrade changes the output of my documents. In new documents, things are > different. +1 pavel

Re: [patch] fix bug 1881

2010-10-06 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > The attached patch removes the hard-coded \clear(double)page command when > using the bib to TOC option. > > fixes http://www.lyx.org/trac/ticket/1881 > > OK? Probably we need some lyx2lyx routine that restores these commands in existing documents. As a user, I would not be p

Re: [patch] fix bug 1881

2010-10-05 Thread Richard Heck
On 10/05/2010 10:25 PM, Uwe Stöhr wrote: The attached patch removes the hard-coded \clear(double)page command when using the bib to TOC option. fixes http://www.lyx.org/trac/ticket/1881 OK? Looks fine, as does the other one. I didn't go through that code in detail, but if it's more or less c

[patch] fix bug 1881

2010-10-05 Thread Uwe Stöhr
The attached patch removes the hard-coded \clear(double)page command when using the bib to TOC option. fixes http://www.lyx.org/trac/ticket/1881 OK? regards Uwe Index: InsetBibtex.cpp === --- InsetBibtex.cpp (revision 35564) +++ I