Re: [patch] fix bug 1879

2005-05-17 Thread Angus Leeming
Georg Baum wrote: >>> BTW, Dialogs::hideSlot() is currently not used. >> Ur. When did that happen? > 13 months ago: > http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/frontends/Dialogs.C.diff?r1=1.31&r2=1.32 Ouch! Thank you! -- Angus

Re: [patch] fix bug 1879

2005-05-17 Thread Georg Baum
Angus Leeming wrote: > If memory serves me right, all insets should emit a signal from their > destructor: Indeed. Thanks! >> A proof-of-concept fix is attached. It works only for "normal" delete >> (the inset must not be selected, and the deletion must not cause a >> paragraph merge. BTW, Dialo

Re: [patch] fix bug 1879

2005-05-17 Thread Angus Leeming
Georg Baum wrote: > Georg Baum wrote: > >> We still have some crashes related to open dialogs, see >> http://bugzilla.lyx.org/show_bug.cgi?id=1879. The attached patch should >> fix them. I am now pretty sure that I understand LFUN_INSET_MODIFY: The >> arguments are the new inset parameters. For m

Re: [patch] fix bug 1879

2005-05-17 Thread Georg Baum
Georg Baum wrote: > We still have some crashes related to open dialogs, see > http://bugzilla.lyx.org/show_bug.cgi?id=1879. The attached patch should > fix them. I am now pretty sure that I understand LFUN_INSET_MODIFY: The > arguments are the new inset parameters. For many insets the first > para

[patch] fix bug 1879

2005-05-10 Thread Georg Baum
We still have some crashes related to open dialogs, see http://bugzilla.lyx.org/show_bug.cgi?id=1879. The attached patch should fix them. I am now pretty sure that I understand LFUN_INSET_MODIFY: The arguments are the new inset parameters. For many insets the first parameter is thee inset name, but