Re: [patch] endPos again

2003-04-02 Thread John Levon
On Wed, Apr 02, 2003 at 08:44:44AM +0200, Alfredo Braunstein wrote: > Could be more that two patches please? Could you apply what I've sent and > then I begin to move the calls from lastPos to endPos? OK sure john

Re: [patch] endPos again

2003-04-01 Thread Alfredo Braunstein
John Levon wrote: > No, two separate patches please. First we change to using endPos() > everywhere, test it, then we make endPos() hold a variable. Could be more that two patches please? Could you apply what I've sent and then I begin to move the calls from lastPos to endPos? Thanks, A

Re: [patch] endPos again

2003-04-01 Thread John Levon
On Wed, Apr 02, 2003 at 12:04:09AM +0200, Alfredo Braunstein wrote: > > But then endpos must be just to return a val from Row, not looking at > > next row and if this is last row in a par or not. > > Seems nice, I will try to do this and repost tomorrow. No, two separate patches please. First we

Re: [patch] endPos again

2003-04-01 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > I do not mean as a function that needs to calculate the endpos, but a > variable endpos, similar to the variable pos_ in Row Ah... I see. (Actually now I remember John talking about this, but I wasn't paying attention ;) > So the only benefit is a bit clearer code? I

Re: [patch] endPos again

2003-04-01 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | | > I'd like to know where you you indent the support for endpos to end | > up. Are you going to introduce a endpos in Row? | I don't know. That was where lastPos was, but you toke it out. Pick a | choice. I don't car

Re: [patch] endPos again

2003-04-01 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > I'd like to know where you you indent the support for endpos to end > up. Are you going to introduce a endpos in Row? I don't know. That was where lastPos was, but you toke it out. Pick a choice. I don't care too much. > Without that I don't see a real benefit. The

Re: [patch] endPos again

2003-04-01 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | 2003-04-01 Alfredo Braunstein <[EMAIL PROTECTED]> | | * lyxrow_funcs.[Ch]: introduce endPos, endPrintablePos. | I'd like to know where you you indent the support for endpos to end up. Are you going to introduce a endpos in Row? Withou

[patch] endPos again

2003-04-01 Thread Alfredo Braunstein
2003-04-01 Alfredo Braunstein <[EMAIL PROTECTED]> * lyxrow_funcs.[Ch]: introduce endPos, endPrintablePos. One of the first next things will be to make rtl to work with the asserts. Regards, Alfredo Index: lyxrow_funcs.C ===