Re: [patch] bug 3439: insertion of quotation mark cannot be undone

2007-04-10 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Jean-Marc Lasgouttes wrote: >> Why the test for selection? Does that avoid a double undo? Jürgen> Yes. >> It stinks that we have to do that. I do not know what the proper >> semantics should be (do not handle undo at all?)

Re: [patch] bug 3439: insertion of quotation mark cannot be undone

2007-04-10 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Why the test for selection? Does that avoid a double undo? Yes. > It stinks that we have to do that. I do not know what the proper semantics > should be (do not handle undo at all?) though. Could you add a FIXME > explainign the issue? Yes. > Jürgen> Jean-Marc, th

Re: [patch] bug 3439: insertion of quotation mark cannot be undone

2007-04-10 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> A missing recordUndo call und some reordering were needed. Jürgen> I'll commit later today if I get no objections. + if (!cur.selection()) + recordUndo(cur); +

[patch] bug 3439: insertion of quotation mark cannot be undone

2007-04-10 Thread Jürgen Spitzmüller
A missing recordUndo call und some reordering were needed. I'll commit later today if I get no objections. Jean-Marc, this is also something for branch. Jürgen Index: src/text3.C === --- src/text3.C (Revision 17755) +++ src/text3.C