Re: [patch] bug 3407: Undo in mathmode

2007-06-07 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Alfredo> Should have "Mathed" in the name then no? > > No because the long term objectove is to merge all these things, I > guess. I think that the nice name should be reserved as a reward for the merger ;-) > And a bit of mystery and surprise makes life more inte

Re: [patch] bug 3407: Undo in mathmode

2007-06-07 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Jean-Marc Lasgouttes wrote: >> The documentation of granAndEraseSelection states: >> >> /// Erase the selection and return it as a string. /// Does not >> handle undo. Does only work if the whole selection is in mathed. A

Re: [patch] bug 3407: Undo in mathmode

2007-06-07 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > The documentation of granAndEraseSelection states: > > /// Erase the selection and return it as a string. > /// Does not handle undo. Does only work if the whole selection is in > mathed. Should have "Mathed" in the name then no? A/

Re: [patch] bug 3407: Undo in mathmode

2007-06-07 Thread Jean-Marc Lasgouttes
> "Bernhard" == Bernhard Roider <[EMAIL PROTECTED]> writes: Bernhard> As i posted in bugzilla there is no crash anymore in current Bernhard> svn. One remaining issue is that undo does not work as it Bernhard> should. The attached patch addresses this, but it surely Bernhard> affects other part

Re: [patch] bug 3407: Undo in mathmode

2007-05-30 Thread Abdelrazak Younes
Bernhard Roider wrote: As i posted in bugzilla there is no crash anymore in current svn. This is perhaps due to my fix of the Cursor::fixIfBroken() method. You know the horrible commit I've done to support my pet feature... Abdel.

[patch] bug 3407: Undo in mathmode

2007-05-30 Thread Bernhard Roider
As i posted in bugzilla there is no crash anymore in current svn. One remaining issue is that undo does not work as it should. The attached patch addresses this, but it surely affects other parts of the code (everything that uses grabAndEraseSelection()), so can someone tell if it is safe to appl