Jean-Marc Lasgouttes wrote:
> I think so.
I applied it. The actual bug number is 2202, not 2022.
Jürgen
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> I was about to post almost the same patch :)
Juergen> Good :-)
>> I think yours is just as good. You should probably add a 'using
>> std::max' somewhere, though.
Juergen> Done. What about
Jean-Marc Lasgouttes wrote:
> I was about to post almost the same patch :)
Good :-)
> I think yours is just as good. You should probably add a 'using
> std::max' somewhere, though.
Done. What about the attached patch? Can it be applied?
Jürgen
Index: src/text2.C
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=2202 Jean-Marc,
Juergen> I found that the attached patch fixes the described crash for
Juergen> me. The cases described in bug 2155 still work. However, I'm
Juergen> not really sur
http://bugzilla.lyx.org/show_bug.cgi?id=2202
Jean-Marc,
I found that the attached patch fixes the described crash for me. The cases
described in bug 2155 still work. However, I'm not really sure I got the
logic. Does this make sense to you?
Jürgen
Index: src/text2.C
===
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> It is something that I quickly hacked together. I did not mean
Georg> to add it to the code now, but if you think that that should be
Georg> done I'll polish it a bit. The Debug::INSET solution does not
Georg> sound too bad. I'll creat
Jean-Marc Lasgouttes wrote:
>> "Georg" == Georg Baum
>> <[EMAIL PROTECTED]>
>> writes:
>
> Georg> - Do we want to fix this bug in 1.4.0? (IMO yes)
>
> Yes, I think so, since it is straightforward.
OK, then I'll commit that.
> This patch looks insteresting. I do not know how we coul
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> See http://bugzilla.lyx.org/show_bug.cgi?id=2022. The problem
Georg> is that the label part is not included in metrics(). A fix is
Georg> attached. Questions:
Georg> - What about the centering problem that Jürgen mentioned?
We can l
See http://bugzilla.lyx.org/show_bug.cgi?id=2022. The problem is that the
label part is not included in metrics(). A fix is attached. Questions:
- What about the centering problem that Jürgen mentioned?
- Do we want to fix this bug in 1.4.0? (IMO yes)
Attached is also a patch for debugging metric
