Re: [patch] bug 1808: undo still has serious problems with memory

2005-07-01 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Lars, is it ok when I leave this declaration changes up to you? I think > they apply to several places, and I feel to alien in this area. I'd just > apply the patch as is. done. Jürgen

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-28 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | On Mon, Jun 27, 2005 at 11:49:58AM +0200, Lars Gullik Bjønnes wrote: >>> A friend declaration is not a forward declaration. Yes, it works with >>> gcc <= 4.0.x, but with 4.1 it will fail. >> > | Oh, is it? I wasn't aware of it. > > Some DR if I am not mistaken. > >

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Jun 27, 2005 at 11:49:58AM +0200, Lars Gullik Bjønnes wrote: >> A friend declaration is not a forward declaration. Yes, it works with >> gcc <= 4.0.x, but with 4.1 it will fail. > | Oh, is it? I wasn't aware of it. Some DR if I am not mistaken.

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-27 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > > A friend declaration is not a forward declaration. Yes, it works with > > gcc <= 4.0.x, but with 4.1 it will fail. > > All the other operators (in StableDocIterator as well as in DocIterator > class) are declared as friend, too. Do you mean that they all should be >

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-27 Thread Andre Poenitz
On Sun, Jun 26, 2005 at 02:15:17PM +0200, Juergen Spitzmueller wrote: > http://bugzilla.lyx.org/show_bug.cgi?id=1808 > > I have been strictly following this recipe from André a.k.a. Kornelia > (minus the cosmetics): > http://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg75701.html > > It fixe

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-27 Thread Andre Poenitz
On Mon, Jun 27, 2005 at 11:49:58AM +0200, Lars Gullik Bjønnes wrote: > A friend declaration is not a forward declaration. Yes, it works with > gcc <= 4.0.x, but with 4.1 it will fail. Oh, is it? I wasn't aware of it. > Other than this the change feels correct. See if you kan get Andre to > comme

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-27 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > A friend declaration is not a forward declaration. Yes, it works with > gcc <= 4.0.x, but with 4.1 it will fail. All the other operators (in StableDocIterator as well as in DocIterator class) are declared as friend, too. Do you mean that they all should be changed? J

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-27 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Index: dociterator.h | === | RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/dociterator.h,v | retrieving revision 1.17 | diff -u -r1.17 dociterator.h | --- dociterator.h 14 Feb 20

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-27 Thread Juergen Spitzmueller
Alfredo Braunstein wrote: > > It fixes the cases described in bug 1808, but since I do not really > > understand the undo stuff, I'd like Alfredo or André to review the patch. > > Not exactly my ballpark (more likely Lars' or Andre's) but I can confirm > that the patch seems to follow the instructi

Re: [patch] bug 1808: undo still has serious problems with memory

2005-06-26 Thread Alfredo Braunstein
Juergen Spitzmueller wrote: > http://bugzilla.lyx.org/show_bug.cgi?id=1808 > > I have been strictly following this recipe from André a.k.a. Kornelia > (minus the cosmetics): > http://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg75701.html > > It fixes the cases described in bug 1808, but si

[patch] bug 1808: undo still has serious problems with memory

2005-06-26 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=1808 I have been strictly following this recipe from André a.k.a. Kornelia (minus the cosmetics): http://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg75701.html It fixes the cases described in bug 1808, but since I do not really understand the undo