Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-10 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i missed that you actually added child/master distinction into the document > preferences. This commit was not intended. I'll revert it (the buttons do nothing yet). Jürgen

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-10 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > * in general, I'd like to have a toggle in children's document dialog where > the user can chose if he wants to edit the children's or the master's > properties. I started with this, but it entails all sorts of changes. i missed that you actually added child/master di

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-10 Thread Pavel Sanda
Pavel Sanda wrote: > great , i'll prepare new patch once Juergen stuff is in. if there is no objection i'll commit this one soon. pavel diff --git a/lib/ui/stdmenus.inc b/lib/ui/stdmenus.inc index f0d8778..6758889 100644 --- a/lib/ui/stdmenus.inc +++ b/lib/ui/stdmenus.inc @@ -463,6 +463,8 @@ Menus

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-09 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > > Then it is defined in a child and not in the master. If not, you found a > > bug that needs to be fixed. > > The second guess is the correct one. It is a bug. Fixed. Jürgen

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-09 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Here you are. I committed this one now. Jürgen

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-08 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > > this question was more for JMarc, he didn't like the previous > > implementation... > > I am still not sure of the need to avoid one or two mouse clicks when > creating a branch (how many times do you do this per day?), you are right than i'm not doing it ten times

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > >> Are you sure that all the places where pasting is invoked allow for a > >> dialog? > > > > Hm, why shouldn't it? > > I don't know... lyxserver? In this case, alert will not try to issue a dialog, but produce a console message and proceed, assuming the default butt

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Thinking about it, I think it is indeed a good idea to have a list of > "unknown" branches in Document>Branches, which can be added to the known > branches by the user. > > However, this is completely orthogonal to my proposal. Here you are. Jürgen Index: src/LyXAction

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: >> Are you sure that all the places where pasting is invoked allow for a >> dialog? > > Hm, why shouldn't it? I don't know... lyxserver? > Then it is defined in a child and not in the master. If not, you found a bug > that needs to be fixed. The second guess is the c

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > Jürgen Spitzmüller wrote: >> Pavel Sanda wrote: >> > so you would agree if i added new lfun, say lfun-branch-add-insert which >> > would do the same as "branch-add branch_inset_insert" in my previous >> > proposal ? >> >> Sure, but please wait until the branch-add lfun is i

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Helge Hafting
Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: The later is not in BufferParams. It only exists because there are instances in the document. To write it differently, the Branch panel would both show the branches of BufferParams and the branches that have not been defined, allowing easily

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > > The later is not in BufferParams. It only exists because there are > > instances in the document. To write it differently, the Branch panel > > would both show the branches of BufferParams and the branches that have > > not been defined, allowing easily to define these

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > so you would agree if i added new lfun, say lfun-branch-add-insert which > > would do the same as "branch-add branch_inset_insert" in my previous > > proposal ? > > Sure, but please wait until the branch-add lfun is in. this question was more for

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > The later is not in BufferParams. It only exists because there are > instances in the document. To write it differently, the Branch panel > would both show the branches of BufferParams and the branches that have > not been defined, allowing easily to define these if ne

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > so you would agree if i added new lfun, say lfun-branch-add-insert which > would do the same as "branch-add branch_inset_insert" in my previous > proposal ? Sure, but please wait until the branch-add lfun is in. Jürgen

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > yes this was the first thing i proposed in my previous patch. the second > > one was the possibility to insert branch inset (not only the branch) > > directly into the document. > > > > if somebody wants to create branch in 90% cases he wants to pu

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Jean-Marc Lasgouttes wrote: >> What about adding the branch to the document, but as 'unconfirmed'? This >> kind of branch could appear in branch settings, with the possibility to >> actually add it. > > I'm not sure how this would actually help. What is the difference

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > yes this was the first thing i proposed in my previous patch. the second > one was the possibility to insert branch inset (not only the branch) > directly into the document. > > if somebody wants to create branch in 90% cases he wants to put it > immediately into the text. Thi

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > No, I don't think we should change the buffer params behind the user's > > > back. > > > > there is nothing to touch wrt buffer params. i just wanted to have menu > > entry or shortcut like Insert->Branch->New branch inset. > > This is a differe

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > What about adding the branch to the document, but as 'unconfirmed'? This > kind of branch could appear in branch settings, with the possibility to > actually add it. I'm not sure how this would actually help. What is the difference between a non-active and an unconfi

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > No, I don't think we should change the buffer params behind the user's > > back. > > there is nothing to touch wrt buffer params. i just wanted to have menu > entry or shortcut like Insert->Branch->New branch inset. This is a different story (unrelated to pasting). If "M-x b

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > * if you paste unknown branches to a document, it issues a dialog that > > > asks you if those should be added to the document's branch list (bug > > > #4462). > > > > would it be possible to allow direct paste of new branch inset into > > docume

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > This patch (for trunk only) does two things: > > * it adds an lfun branch-add, > > * if you paste unknown branches to a document, it issues a dialog that asks > you if those should be added to the document's branch list (bug #4462). What about adding the branch to t

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > * if you paste unknown branches to a document, it issues a dialog that > > asks you if those should be added to the document's branch list (bug > > #4462). > > would it be possible to allow direct paste of new branch inset into > document? No, I don't think we should change

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > This patch (for trunk only) does two things: > > * it adds an lfun branch-add, > > * if you paste unknown branches to a document, it issues a dialog that asks > you if those should be added to the document's branch list (bug #4462). would it be possible to allow dire

[patch] branch paste check and LFUN_BRANCH_ADD

2009-07-07 Thread Jürgen Spitzmüller
This patch (for trunk only) does two things: * it adds an lfun branch-add, * if you paste unknown branches to a document, it issues a dialog that asks you if those should be added to the document's branch list (bug #4462). What is missing is the possibility to add the branch to the master if yo