RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-06-29 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, June 27, 2012 9:31 AM >Is it unity bug > https://bugs.launchpad.net/ubuntu/+source/libdbusmenu/+bug/994564 >that you see? In this case, this has just been fixed in ubuntu >precise-proposed. The patch there fixes the problem for me

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-06-27 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, June 27, 2012 9:31 AM >>Le 21/05/2012 08:02, Scott Kostyshak a écrit : >> In any case, it doesn't look like anyone has reproduced this and no one has >> complained about it before so I guess we should not do anything about it? >Is

Re: [patch] ampersand + shortcut leaves an underscore in menu

2012-06-27 Thread Jean-Marc Lasgouttes
Le 21/05/2012 08:02, Scott Kostyshak a écrit : In any case, it doesn't look like anyone has reproduced this and no one has complained about it before so I guess we should not do anything about it? Is it unity bug https://bugs.launchpad.net/ubuntu/+source/libdbusmenu/+bug/994564 that you see?

Re: [patch] ampersand + shortcut leaves an underscore in menu

2012-06-03 Thread Tommaso Cucinotta
On 23/05/12 00:24, Scott Kostyshak wrote: From: Tommaso Cucinotta [tomm...@lyx.org] FYI, I cannot reproduce on my Ubuntu 12.04: Good to know. Thanks! I have the same libqt4-dev version. I use 64-bit. Do you use 64-bit? Yep. T.

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-22 Thread Scott Kostyshak
From: Tommaso Cucinotta [tomm...@lyx.org] Sent: Tuesday, May 22, 2012 7:17 PM >> In any case, it doesn't look like anyone has reproduced this and no one has >> complained about it before so I guess we should not do anything about it? >FYI, I cannot reproduce on my Ubuntu 12.04: Good to know. Th

Re: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-22 Thread Tommaso Cucinotta
On 21/05/12 07:02, Scott Kostyshak wrote: In any case, it doesn't look like anyone has reproduced this and no one has complained about it before so I guess we should not do anything about it? FYI, I cannot reproduce on my Ubuntu 12.04: ii libqt4-dev 4:4.8.1-0ubun

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-20 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, May 20, 2012 1:36 PM >I think that some code (qt? our own?) assumes that "& " means that " " >is a shortcut and is thus underlined. I thought we were supposed to >repalce & with && automatically to avoid that. It might be that the >rule

Re: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-20 Thread Jean-Marc Lasgouttes
Le 20/05/12 13:25, Scott Kostyshak a écrit : *From:* Vincent van Ravesteijn [v...@lyx.org] *Sent:* Sunday, May 20, 2012 7:05 AM >Isn't this exactly what is expected ? The "|F" means that the F is the accelerator, and thus it will be >underlined. I don't see a relation with the ampersand. I agr

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-20 Thread Scott Kostyshak
From: Vincent van Ravesteijn [v...@lyx.org] Sent: Sunday, May 20, 2012 7:05 AM >Isn't this exactly what is expected ? The "|F" means that the F is the >accelerator, and thus it will be >underlined. I don't see a relation with the >ampersand. I agree that F should be underlined. But for me (with

Re: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-20 Thread Vincent van Ravesteijn
Op 20-5-2012 12:50, Scott Kostyshak schreef: In the menu when there is an entry that has an ampersand and it has a shortcut, an unnecessary underscore is displayed. For example, instead of "Find & Replace (Quick)..." I see "_Find & Replace (Quick)...". I see this behavior on Ubuntu 12.04 with Q

[patch] ampersand + shortcut leaves an underscore in menu

2012-05-20 Thread Scott Kostyshak
In the menu when there is an entry that has an ampersand and it has a shortcut, an unnecessary underscore is displayed. For example, instead of "Find & Replace (Quick)..." I see "_Find & Replace (Quick)...". I see this behavior on Ubuntu 12.04 with Qt 4.8.1. The attached patch fixes this. Note