Re: [patch] a rowbreakpoint

2003-10-25 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Alfredo Braunstein wrote: > >> A simplistic rowbreakpoint sanitizing patch... that works (or seems to). >> It's still somewhat ugly (I'm cleaning it a bit) but loads the UserGuide >> correctly. > > But it's not working fine. It leaves too much space sometimes and ther

Re: [patch] a rowbreakpoint

2003-10-25 Thread Alfredo Braunstein
Martin Vermeer wrote: > Funny thing is, I looked at this yesterday and wondered, would that be > the culprit? > Then I had to take care of other things and go home, and couldn't > check it out ;-) Thanks for looking at it anyways If you have the time and will, I'd really appreciate if you ca

Re: [patch] a rowbreakpoint

2003-10-25 Thread Martin Vermeer
On Sat, Oct 25, 2003 at 12:18:05AM +0200, Alfredo Braunstein spake thusly: > This seems to be the culprit. (even if your change seems reasonable and > other parts may be adjusted instead) > > Alfredo Funny thing is, I looked at this yesterday and wondered, would that be the culprit? Then I had

Re: [patch] a rowbreakpoint

2003-10-24 Thread Alfredo Braunstein
Andre Poenitz wrote: > Anyway, that's rather cosmetical. Of course it needs to be fixed, but > I'd rather have your sanitize.diff in, and I'll have a closer look in > the evening. This seems to be the culprit. (even if your change seems reasonable and other parts may be adjusted instead) Alfredo

Re: [patch] a rowbreakpoint

2003-10-24 Thread Andre Poenitz
On Fri, Oct 24, 2003 at 04:46:31PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Fri, Oct 24, 2003 at 04:22:32PM +0200, Alfredo Braunstein wrote: > >> Andre Poenitz wrote: > >> > >> > Could you send the .lyx with the problem? > >> > >> It's the userguide. 3.1.3 "Fine tunning t

Re: [patch] a rowbreakpoint

2003-10-24 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Fri, Oct 24, 2003 at 04:22:32PM +0200, Alfredo Braunstein wrote: >> Andre Poenitz wrote: >> >> > Could you send the .lyx with the problem? >> >> It's the userguide. 3.1.3 "Fine tunning the defaults." >> But i see different rowbreaking even on the first paragraphs (in cu

Re: [patch] a rowbreakpoint

2003-10-24 Thread Andre Poenitz
On Fri, Oct 24, 2003 at 04:22:32PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Could you send the .lyx with the problem? > > It's the userguide. 3.1.3 "Fine tunning the defaults." > But i see different rowbreaking even on the first paragraphs (in current cvs > there is typically

Re: [patch] a rowbreakpoint

2003-10-24 Thread Alfredo Braunstein
Andre Poenitz wrote: > Could you send the .lyx with the problem? It's the userguide. 3.1.3 "Fine tunning the defaults." But i see different rowbreaking even on the first paragraphs (in current cvs there is typically too much space spreaded around wrt. yesterday night's cvs) Alfredo

Re: [patch] a rowbreakpoint

2003-10-24 Thread Andre Poenitz
On Fri, Oct 24, 2003 at 04:08:42PM +0200, Alfredo Braunstein wrote: > Alfredo Braunstein wrote: > > > Andre Poenitz wrote: > > > >> would be closer to the intention. This way, the check you added to the > >> beginning of rowBreakPoint would not be needed as well. > > > > But the doesn't the heig

Re: [patch] a rowbreakpoint

2003-10-24 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> would be closer to the intention. This way, the check you added to the >> beginning of rowBreakPoint would not be needed as well. > > But the doesn't the height etc have to be set on the row? > > Anyway I have to solve this first (snapshot

Re: [patch] a rowbreakpoint

2003-10-24 Thread Alfredo Braunstein
Andre Poenitz wrote: > Well, I think it _is_ a special case, so better handle it as such > in the place where it occurs and do not shift responsibility to > rowBreakPoint. Ok, I'll do it. Alfredo

Re: [patch] a rowbreakpoint

2003-10-24 Thread Andre Poenitz
On Fri, Oct 24, 2003 at 01:52:12PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > would be closer to the intention. This way, the check you added to the > > beginning of rowBreakPoint would not be needed as well. > > But the doesn't the height etc have to be set on the row? Hm ye

Re: [patch] a rowbreakpoint

2003-10-24 Thread Andre Poenitz
On Fri, Oct 24, 2003 at 01:19:43PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Could you please send patches as attachment? They arrive somewhat broken > > here. > > > > Look e.g. at the line starting with '> endl;' below. THis should belong > > to the line above. > > It must b

Re: [patch] a rowbreakpoint

2003-10-24 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > A simplistic rowbreakpoint sanitizing patch... that works (or seems to). > It's still somewhat ugly (I'm cleaning it a bit) but loads the UserGuide > correctly. But it's not working fine. It leaves too much space sometimes and there are several visual glitches on the U

Re: [patch] a rowbreakpoint

2003-10-24 Thread Alfredo Braunstein
Andre Poenitz wrote: > Could you please send patches as attachment? They arrive somewhat broken > here. > > Look e.g. at the line starting with '> endl;' below. THis should belong > to the line above. It must be the mua autobreak "feature", Sorry. Attached now. Alfredo ? text.C-goood ? text3-sa

Re: [patch] a rowbreakpoint

2003-10-24 Thread Andre Poenitz
On Fri, Oct 24, 2003 at 01:08:47PM +0200, Alfredo Braunstein wrote: > A simplistic rowbreakpoint sanitizing patch... that works (or seems to). > It's still somewhat ugly (I'm cleaning it a bit) but loads the UserGuide > correctly. > > Beware that it introduces a lot of asserts, but if you have the

[patch] a rowbreakpoint

2003-10-24 Thread Alfredo Braunstein
A simplistic rowbreakpoint sanitizing patch... that works (or seems to). It's still somewhat ugly (I'm cleaning it a bit) but loads the UserGuide correctly. Beware that it introduces a lot of asserts, but if you have the time, please test it. Index: lyxrow_funcs.C