Re: [patch] Source highlighting of comments

2007-11-27 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > its in. I would welcome to a backport to 1.5.3. Jürgen

Re: [patch] Source highlighting of comments

2007-11-26 Thread Jean-Marc Lasgouttes
Bernhard Reiter <[EMAIL PROTECTED]> writes: > Quoting Cletus (The Simpsons Movie): "I just can't!" > Lacking commit privileges. Maybe someone else "can". > > Bernhard (Reiter, not Roider, for that matter) I guess you found the culprit. Sorry ! JMarc

Re: [patch] Source highlighting of comments

2007-11-26 Thread Pavel Sanda
> Lacking commit privileges. Maybe someone else "can". its in. pavel

Re: [patch] Source highlighting of comments

2007-11-26 Thread Bernhard Reiter
Am Montag, den 26.11.2007, 10:29 +0100 schrieb Jean-Marc Lasgouttes: > Apply it, then. Quoting Cletus (The Simpsons Movie): "I just can't!" Lacking commit privileges. Maybe someone else "can". Bernhard (Reiter, not Roider, for that matter)

Re: [patch] Source highlighting of comments

2007-11-26 Thread Jean-Marc Lasgouttes
Bernhard Reiter <[EMAIL PROTECTED]> writes: > Agree, in principle. Still, I don't know if I could do it much more > lucidly just using qt's string functions. Don't know much about qt strings... I just thought that a find and a count would almost be enough. > See attached; it now does get even n

Re: [patch] Source highlighting of comments

2007-11-25 Thread Bernhard Reiter
> I wrote: > > > ATM, in the source view (eg in the preamble), the last character before > > a comment (ie percent sign) is greyed out as if part of the comment. The > > attached patch should fix this behavior. > > Makes me wonder whether we need a regexp (and not of the most readable > kind) for

Re: [patch] Source highlighting of comments

2007-11-23 Thread Bernhard Reiter
That was a little misleading. To recap: Currently, the character *before the percent sign* is incorrectly greyed out. That's what my patch fixes. It still leaves the percent sign (and comment) greyed out. Bernhard Reiter Am Freitag, den 23.11.2007, 13:17 +0100 schrieb Bernhard Reiter: > ATM, in

Re: [patch] Source highlighting of comments

2007-11-23 Thread Jean-Marc Lasgouttes
Bernhard Reiter <[EMAIL PROTECTED]> writes: > ATM, in the source view (eg in the preamble), the last character before > a comment (ie percent sign) is greyed out as if part of the comment. The > attached patch should fix this behavior. Makes me wonder whether we need a regexp (and not of the most

[patch] Source highlighting of comments

2007-11-23 Thread Bernhard Reiter
ATM, in the source view (eg in the preamble), the last character before a comment (ie percent sign) is greyed out as if part of the comment. The attached patch should fix this behavior. Bernhard Reiter Index: src/frontends/qt4/LaTeXHighlighter.cpp ==