Re: [patch] Re: RTL justification bug

2007-07-09 Thread Dov Feldstern
José Matos wrote: On Monday 09 July 2007 09:50:27 Abdelrazak Younes wrote: I guess the problem is that nobody understands this bidi stuff like you do. I would tend to say "go ahead!", but I am not sure what are my credentials to do so :) Same position for me. The patch looks not so complicate s

Re: [patch] Re: RTL justification bug

2007-07-09 Thread José Matos
On Monday 09 July 2007 09:50:27 Abdelrazak Younes wrote: > > I guess the problem is that nobody understands this bidi stuff like > > you do. I would tend to say "go ahead!", but I am not sure what are my > > credentials to do so :) > > Same position for me. The patch looks not so complicate so I'd

Re: [patch] Re: RTL justification bug

2007-07-09 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> I still haven't gotten any other responses regarding this patch. Dov> I think it's safe, I've been working with it since I first sent Dov> it to the list and haven't run into any trouble. I don't think Dov> that

Re: [patch] Re: RTL justification bug

2007-07-09 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> I still haven't gotten any other responses regarding this patch. Dov> I think it's safe, I've been working with it since I first sent Dov> it to the list and haven't run into any trouble. I don't think Dov> that it's *crucial* that this

Re: [patch] Re: RTL justification bug

2007-07-08 Thread Dov Feldstern
Dov Feldstern wrote: José Matos wrote: On Thursday 28 June 2007 21:00:28 Dov Feldstern wrote: I haven't gotten any further comments regarding this patch. Is it OK to go in? Are you sure it is safe? Could have the opinion of other RTL users? Would anyone like the patch attached at http://

Re: [patch] Re: RTL justification bug

2007-06-28 Thread Dov Feldstern
José Matos wrote: On Thursday 28 June 2007 21:00:28 Dov Feldstern wrote: I haven't gotten any further comments regarding this patch. Is it OK to go in? Are you sure it is safe? Could have the opinion of other RTL users? Would anyone like the patch attached at http://permalink.gmane.org/gm

Re: [patch] Re: RTL justification bug

2007-06-28 Thread José Matos
On Thursday 28 June 2007 21:00:28 Dov Feldstern wrote: > I haven't gotten any further comments regarding this patch. Is it OK to > go in? Are you sure it is safe? Could have the opinion of other RTL users? -- José Abílio

cusorsX speedup? (was: Re: [patch] Re: RTL justification bug)

2007-06-28 Thread Dov Feldstern
Dov Feldstern wrote: Attached find a patch for this bug. OK? Twice almost the same code sequence. Any chance of factoring this out? I know... But if you'll take a look at the two functions (paintText and cursorX), the loop at the heart of them is very similar, and a lot of the same things

Re: [patch] Re: RTL justification bug

2007-06-28 Thread Dov Feldstern
Dov Feldstern wrote: Stefan Schimanski wrote: Ok, after rereading your previous mail I got it. Would be good to put a better documentation there like: // Spaces at line breaks in bidi text can appear visually in the middle // of a row and must be skipped during painting: // * logically "abc_

Re: [patch] Re: RTL justification bug

2007-06-26 Thread Dov Feldstern
Stefan Schimanski wrote: Ok, after rereading your previous mail I got it. Would be good to put a better documentation there like: // Spaces at line breaks in bidi text can appear visually in the middle // of a row and must be skipped during painting: // * logically "abc_[HEBREW_\nHEBREW]" //

Re: [patch] Re: RTL justification bug

2007-06-26 Thread Stefan Schimanski
Am 26.06.2007 um 21:25 schrieb Dov Feldstern: Stefan Schimanski wrote: +// If the last logical character is a separator, skip it, unless +// it's in the last row of a paragraph +if (end > 0 && end < par.size() && par.isSeparator(end - 1)) +skipped_sep_vpos = bidi.log2vis(

Re: [patch] Re: RTL justification bug

2007-06-26 Thread Dov Feldstern
Martin Vermeer wrote: On Mon, Jun 25, 2007 at 11:17:15PM +0300, Dov Feldstern wrote: Dov Feldstern wrote: Hi! Here's another RTL regression --- I think this should be really easy to solve for anyone familiar with the painting code. I'd be happy to try and help out if necessary. http://bugz

Re: [patch] Re: RTL justification bug

2007-06-26 Thread Dov Feldstern
Stefan Schimanski wrote: +// If the last logical character is a separator, skip it, unless +// it's in the last row of a paragraph +if (end > 0 && end < par.size() && par.isSeparator(end - 1)) +skipped_sep_vpos = bidi.log2vis(end - 1); I thought it's about the visually last

Re: [patch] Re: RTL justification bug

2007-06-25 Thread Martin Vermeer
On Mon, Jun 25, 2007 at 11:17:15PM +0300, Dov Feldstern wrote: > Dov Feldstern wrote: > >Hi! > > > >Here's another RTL regression --- I think this should be really easy to > >solve for anyone familiar with the painting code. I'd be happy to try > >and help out if necessary. > > > >http://bugzilla

Re: [patch] Re: RTL justification bug

2007-06-25 Thread Stefan Schimanski
+ // If the last logical character is a separator, skip it, unless + // it's in the last row of a paragraph + if (end > 0 && end < par.size() && par.isSeparator(end - 1)) + skipped_sep_vpos = bidi.log2vis(end - 1); I thought it's about the visually last (or first

[patch] Re: RTL justification bug

2007-06-25 Thread Dov Feldstern
Dov Feldstern wrote: Hi! Here's another RTL regression --- I think this should be really easy to solve for anyone familiar with the painting code. I'd be happy to try and help out if necessary. http://bugzilla.lyx.org/show_bug.cgi?id=3889 Thanks! Dov Hi! Attached find a patch for this