Re: [patch] Putting ForceLTR to use

2007-11-03 Thread Dov Feldstern
Andre Poenitz wrote: On Thu, Nov 01, 2007 at 10:58:29PM +0200, Dov Feldstern wrote: Richard Heck wrote: Probably should be asInsetCollapsable(). Hmm, yes. I tried to conform to the example of asTextInset, but I now notice that asInsetMath goes the other way... Should I change asTextInset -> a

Re: [patch] Putting ForceLTR to use

2007-11-01 Thread Andre Poenitz
On Thu, Nov 01, 2007 at 11:24:37PM +0200, Dov Feldstern wrote: > Dov Feldstern wrote: >> Richard Heck wrote: >>> Some silly comments. +/// is this inset based on the CollapsableInset class? +virtual InsetCollapsable * asCollapsableInset() { return 0; } +/// is this inset

Re: [patch] Putting ForceLTR to use

2007-11-01 Thread Andre Poenitz
On Thu, Nov 01, 2007 at 10:58:29PM +0200, Dov Feldstern wrote: > Richard Heck wrote: >> Some silly comments. >>> +/// is this inset based on the CollapsableInset class? >>> +virtual InsetCollapsable * asCollapsableInset() { return 0; } >>> +/// is this inset based on the CollapsableInse

Re: [patch] Putting ForceLTR to use

2007-11-01 Thread Dov Feldstern
Dov Feldstern wrote: Richard Heck wrote: Some silly comments. +/// is this inset based on the CollapsableInset class? +virtual InsetCollapsable * asCollapsableInset() { return 0; } +/// is this inset based on the CollapsableInset class? +virtual InsetCollapsable const * asCollap

Re: [patch] Putting ForceLTR to use

2007-11-01 Thread Dov Feldstern
Martin Vermeer wrote: Hmmm, I see the ERT calls its own version of resetParagraphsFont(). I believe it can be removed so it uses the InsetCollapsable one. Saves a few lines. (I think I planned on doing this, but forgot.) That doesn't impact this patch, though, does it? Here I'm using the For

Re: [patch] Putting ForceLTR to use

2007-11-01 Thread Dov Feldstern
Richard Heck wrote: Some silly comments. +/// is this inset based on the CollapsableInset class? +virtual InsetCollapsable * asCollapsableInset() { return 0; } +/// is this inset based on the CollapsableInset class? +virtual InsetCollapsable const * asCollapsableInset() const {

Re: [patch] Putting ForceLTR to use

2007-10-30 Thread Martin Vermeer
On Wed, Oct 31, 2007 at 01:03:16AM +0200, Dov Feldstern wrote: > Hi! > > Martin --- thanks for all your work towards the ForceLTR option! > > The attached patch uses this option in order to make sure that insets > which define this option are put in an LTR environment if they are in > RTL surro

Re: [patch] Putting ForceLTR to use

2007-10-30 Thread Richard Heck
Some silly comments. + /// is this inset based on the CollapsableInset class? + virtual InsetCollapsable * asCollapsableInset() { return 0; } + /// is this inset based on the CollapsableInset class? + virtual InsetCollapsable const * asCollapsableInset() const { return 0;

[patch] Putting ForceLTR to use

2007-10-30 Thread Dov Feldstern
Hi! Martin --- thanks for all your work towards the ForceLTR option! The attached patch uses this option in order to make sure that insets which define this option are put in an LTR environment if they are in RTL surroundings (which is why I originally asked for this option). To this end, I