Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Andre Poenitz
On Wed, May 28, 2003 at 12:53:39AM +0200, Lars Gullik Bjønnes wrote: > This patch introduces ParagraphList::const_iterator, and adjust stuff > to fit. All problems larger than --><-- has been solved by a > const_cast. @@ -243,12 +243,12 @@ int getEndLabel(ParagraphList::iterator { Parag

Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Andre Poenitz
On Wed, May 28, 2003 at 08:35:01AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | > to fit. All problems larger than --><-- has been solved by a > | > const_cast. > > This ^^ > > | Wouldn't it be better in such cases to change the functions' signature t

Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Andre Poenitz
On Wed, May 28, 2003 at 09:05:23AM +0200, Lars Gullik Bjønnes wrote: > | I think std::list<>::const_iterator has a corresponding constructor. > > Show me. I don't find it in the Standard right now. But: template struct _List_iterator : public _List_iterator_base { typedef _List

Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Andre Poenitz
On Wed, May 28, 2003 at 09:44:29AM +0200, Lars Gullik Bjønnes wrote: > | It certainly is undefined behaviour. But every std::list<>::iterator I know > | of is binary compatible with its corresponding std::list<>::const_iterator > | (in contrast to your string/int example) even if that's not require

Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Andre Poenitz
On Wed, May 28, 2003 at 09:58:46AM +0200, Lars Gullik Bjønnes wrote: > but it is not iterator -> const_iterator that is cumbersom (as you > have shown), but const_iterator -> iterator. Ah ok. Well for this the reinterpret_cast would work too, but we shouldn't use it as this would not be eliminated

[patch] ParagraphList::const_iterator

2003-05-30 Thread Lars Gullik Bjønnes
This patch introduces ParagraphList::const_iterator, and adjust stuff to fit. All problems larger than --><-- has been solved by a const_cast. Have a look if you want to. ? src/frontends/xforms/lyx_forms.h ? src/frontends/xforms/lyx_xpm.h Index: src/ParagraphList.C =

Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | > Perhaps. But I am not willing to open that issue now... It is some | > easy to come in the situation that you need to convert | > ParagraphList::iterator to ParagraphList::const_iterator and that is | > reall cumbersome. | | I think std::list<>::const

Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | > to fit. All problems larger than --><-- has been solved by a | > const_cast. This ^^ | Wouldn't it be better in such cases to change the functions' signature to | | int getEndLabel(ParagraphList::const_iterator... Perhaps. But I am not wil

Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, May 28, 2003 at 09:44:29AM +0200, Lars Gullik Bjønnes wrote: | > | It certainly is undefined behaviour. But every std::list<>::iterator I know | > | of is binary compatible with its corresponding std::list<>::const_iterator | > | (in contrast to

Re: [Devel] [patch] ParagraphList::const_iterator

2003-05-30 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, May 28, 2003 at 09:05:23AM +0200, Lars Gullik Bjønnes wrote: | > | I think std::list<>::const_iterator has a corresponding constructor. | > | > Show me. | | I don't find it in the Standard right now. Right... :-) | But: | | template |