Re: [patch] Minimize xforms dependencies

2003-02-10 Thread Andre Poenitz
On Mon, Feb 10, 2003 at 09:11:12AM +, Angus Leeming wrote: > > Opinions? > > I think that the idea is good. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)

Re: [patch] Minimize xforms dependencies

2003-02-10 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> John Levon <[EMAIL PROTECTED]> writes: Lars> | On Sun, Feb 09, 2003 at 10:51:07PM +0100, Lars Gullik Bj?nnes wrote: Lars> | Lars> | > I have been trying to get xforms specific stuff out of Lars> config.h, I Lars> | Lars> | Why

Re: [patch] Minimize xforms dependencies

2003-02-10 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > I have been trying to get xforms specific stuff out of config.h, I > have moved FORMS_H_LOCATION and XPM_H_LOCATION out of there and into a > xf-config.h that is placed in src/frontends/xforms. > > Opinions? I think that the idea is good. -- Angus

Re: [patch] Minimize xforms dependencies

2003-02-09 Thread Lars Gullik Bjønnes
"Garst R. Reese" <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > | > Opinions? | It is hard to imagine that things could get worse. I finally got 1.4CVS | to compile. | After using the options specified for xforms in the xforms patch, which | then made xforms compile fail because my

Re: [patch] Minimize xforms dependencies

2003-02-09 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Mon, Feb 10, 2003 at 01:13:00AM +0100, Lars Gullik Bj?nnes wrote: | | > | If we have an xforms-dependent change in the config file, and somebody | > | forgets to include xf-config.h or whatever. | > | > The it won't compile... | | Not necessarily tru

Re: [patch] Minimize xforms dependencies

2003-02-09 Thread John Levon
On Mon, Feb 10, 2003 at 01:13:00AM +0100, Lars Gullik Bj?nnes wrote: > | If we have an xforms-dependent change in the config file, and somebody > | forgets to include xf-config.h or whatever. > > The it won't compile... Not necessarily true. #define OOH_CAN_USER_FANCY_THING #ifdef OOH_CAN_USE

Re: [patch] Minimize xforms dependencies

2003-02-09 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Mon, Feb 10, 2003 at 01:08:37AM +0100, Lars Gullik Bj?nnes wrote: | | > | > have moved FORMS_H_LOCATION and XPM_H_LOCATION out of there and into a | > | > xf-config.h that is placed in src/frontends/xforms. | > | | > | Looks like a brittle change to me

Re: [patch] Minimize xforms dependencies

2003-02-09 Thread John Levon
On Mon, Feb 10, 2003 at 01:08:37AM +0100, Lars Gullik Bj?nnes wrote: > | > have moved FORMS_H_LOCATION and XPM_H_LOCATION out of there and into a > | > xf-config.h that is placed in src/frontends/xforms. > | > | Looks like a brittle change to me. > > What makes it brittle? If we have an xforms-

Re: [patch] Minimize xforms dependencies

2003-02-09 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | > have moved FORMS_H_LOCATION and XPM_H_LOCATION out of there and into a | > xf-config.h that is placed in src/frontends/xforms. | | Looks like a brittle change to me. What makes it brittle? -- Lgb

Re: [patch] Minimize xforms dependencies

2003-02-09 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Sun, Feb 09, 2003 at 10:51:07PM +0100, Lars Gullik Bj?nnes wrote: | | > I have been trying to get xforms specific stuff out of config.h, I | | Why ? So that a configure change from qt to xforms will not require all code to be rebuilt... Besides I do

Re: [patch] Minimize xforms dependencies

2003-02-09 Thread John Levon
On Sun, Feb 09, 2003 at 10:51:07PM +0100, Lars Gullik Bj?nnes wrote: > I have been trying to get xforms specific stuff out of config.h, I Why ? > have moved FORMS_H_LOCATION and XPM_H_LOCATION out of there and into a > xf-config.h that is placed in src/frontends/xforms. Looks like a brittle cha

[patch] Minimize xforms dependencies

2003-02-09 Thread Lars Gullik Bjønnes
I have been trying to get xforms specific stuff out of config.h, I have moved FORMS_H_LOCATION and XPM_H_LOCATION out of there and into a xf-config.h that is placed in src/frontends/xforms. Opinions? Index: config/configure.ac ===