Re: [patch] LyX bash completion

2012-09-24 Thread Scott Kostyshak
On Mon, Sep 24, 2012 at 6:49 PM, Richard Heck wrote: > On 09/24/2012 03:54 PM, Pavel Sanda wrote: >> >> Scott Kostyshak wrote: >>> >>> Are these OK to go in to branch and master? >> >> Looks fine if tested ;) Branch is Richard's call. >> > I don't know anything about this completion stuff. How do

Re: [patch] LyX bash completion

2012-09-24 Thread Richard Heck
On 09/24/2012 03:54 PM, Pavel Sanda wrote: Scott Kostyshak wrote: Are these OK to go in to branch and master? Looks fine if tested ;) Branch is Richard's call. I don't know anything about this completion stuff. How do you feel about it? rh

Re: [patch] LyX bash completion

2012-09-24 Thread Pavel Sanda
Scott Kostyshak wrote: > Are these OK to go in to branch and master? Looks fine if tested ;) Branch is Richard's call. Pavel

Re: [patch] LyX bash completion

2012-09-21 Thread Scott Kostyshak
Hi Cengiz, Thanks for the response! It's always nice to see original authors sticking around. On Fri, Sep 21, 2012 at 3:21 PM, Cengiz Günay wrote: > On Wed, Sep 19, 2012 at 3:48 AM, Scott Kostyshak wrote: >> I don't understand the following: >> case "$last" in >> +\(--export|-e\

Re: [patch] LyX bash completion

2012-09-21 Thread Cengiz Günay
Hi Scott, Thanks for improving the script. I'm also CC'ing to Pavel, who was maintaining this feature last time in 2010. I'm not sure, but maybe it's a good idea to open a ticket for resolving these issues. Maybe one of the Lyx-devel regulars can recommend a solution. See more responses below. O

Re: [patch] LyX bash completion

2012-09-20 Thread Scott Kostyshak
On Thu, Sep 20, 2012 at 6:14 PM, Richard Heck wrote: > On 09/20/2012 05:00 PM, Scott Kostyshak wrote: >> >> On Thu, Sep 20, 2012 at 4:44 PM, Pavel Sanda wrote: >>> >>> Scott Kostyshak wrote: If the hardcoding is desired, then I will manually make the updates: >>> >>> I think hardcoding

Re: [patch] LyX bash completion

2012-09-20 Thread Richard Heck
On 09/20/2012 05:00 PM, Scott Kostyshak wrote: On Thu, Sep 20, 2012 at 4:44 PM, Pavel Sanda wrote: Scott Kostyshak wrote: If the hardcoding is desired, then I will manually make the updates: I think hardcoding is fine here. Pavel OK, updated patch attached. Feel free to commit unless someon

Re: [patch] LyX bash completion

2012-09-20 Thread Scott Kostyshak
On Thu, Sep 20, 2012 at 4:44 PM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> If the hardcoding is desired, then I will manually make the updates: > > I think hardcoding is fine here. Pavel OK, updated patch attached. Thanks, Scott diff --git a/lib/scripts/bash_completion b/lib/scripts/bash_c

Re: [patch] LyX bash completion

2012-09-20 Thread Pavel Sanda
Scott Kostyshak wrote: > If the hardcoding is desired, then I will manually make the updates: I think hardcoding is fine here. Pavel

[patch] LyX bash completion

2012-09-19 Thread Scott Kostyshak
(CC'ing original author) Attached is a patch with some changes to the bash completion script. I don't understand the following: case "$last" in +\(--export|-e\)) Why is the second line not simply "--export|-e)" ? Instead of hardcoding the -dbg options, this patch makes it so the