Re: [patch] LQApplication cleanup

2006-06-03 Thread Georg Baum
Am Samstag, 3. Juni 2006 18:12 schrieb Abdelrazak Younes: > I know that, the question was more about the destruction of > BufferView::Pimpl which I don't see in lyx_gui. AFAIU, we shall make > sure that this destruction happens after the one of QApplication (I am > not saying it does not, just t

Re: [patch] LQApplication cleanup

2006-06-03 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 3. Juni 2006 17:15 schrieb Abdelrazak Younes: Yes I mean destruction. Right now, WorkArea creation is done in BufferView::Pimpl::Pimpl construction (I don't know when this construction happen). workarea_.reset(WorkAreaFactory::create(*owner_, width, height));

Re: [patch] LQApplication cleanup

2006-06-03 Thread Georg Baum
Am Samstag, 3. Juni 2006 17:15 schrieb Abdelrazak Younes: > Yes I mean destruction. Right now, WorkArea creation is done in > BufferView::Pimpl::Pimpl construction (I don't know when this > construction happen). > >workarea_.reset(WorkAreaFactory::create(*owner_, width, height)); >screen_

Re: [patch] LQApplication cleanup

2006-06-03 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 3. Juni 2006 16:47 schrieb Abdelrazak Younes: I see it's too late. No big deal but please let's discuss before you commit your upcoming patch. See my other mail. I will not commit that for some days, since it needs testing. OK. By the way, I think the initiali

Re: [patch] LQApplication cleanup

2006-06-03 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 3. Juni 2006 16:39 schrieb Abdelrazak Younes: Did you read my post Georg? I did, but it came in after I sent my previous mail. Here is what I have currently so if you think there will be conflict, I think we should discuss before you apply this to qt4. There w

Re: [patch] LQApplication cleanup

2006-06-03 Thread Georg Baum
Am Samstag, 3. Juni 2006 16:47 schrieb Abdelrazak Younes: > I see it's too late. No big deal but please let's discuss before you > commit your upcoming patch. See my other mail. I will not commit that for some days, since it needs testing. > By the way, I think the initialisation problem comes

Re: [patch] LQApplication cleanup

2006-06-03 Thread Georg Baum
Am Samstag, 3. Juni 2006 16:39 schrieb Abdelrazak Younes: > Did you read my post Georg? I did, but it came in after I sent my previous mail. > Here is what I have currently so if you think there will be conflict, I > think we should discuss before you apply this to qt4. There will be a technica

Re: [patch] LQApplication cleanup

2006-06-03 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Georg Baum wrote: This patch removes the empty LQApplication destructor, since the compiler will generate one as needed. It makes my upcoming "QApplication exit crash" patch a tiny bit smaller and goes in now. Did you read my post Georg? Here is what I have currently

Re: [patch] LQApplication cleanup

2006-06-03 Thread Abdelrazak Younes
Georg Baum wrote: This patch removes the empty LQApplication destructor, since the compiler will generate one as needed. It makes my upcoming "QApplication exit crash" patch a tiny bit smaller and goes in now. Did you read my post Georg? Here is what I have currently so if you think there wil

[patch] LQApplication cleanup

2006-06-03 Thread Georg Baum
This patch removes the empty LQApplication destructor, since the compiler will generate one as needed. It makes my upcoming "QApplication exit crash" patch a tiny bit smaller and goes in now. Georg Log: * src/frontends/qt3/lyx_gui.C (LQApplication): remove empty destructor