RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-04-18 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, April 18, 2012 6:50 AM >Don't bother with it. OTOH, your gentle nudge made me commit your patch >:) I just removed the new useless parameter 'backwards' of putSelectionA

Re: [patch] LFUN_WORD_REPLACE does not clear selection

2012-04-18 Thread Jean-Marc Lasgouttes
Le 17/04/2012 23:28, Scott Kostyshak a écrit : From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Monday, March 19, 2012 9:21 AM I wonder whether in replaceAll whether the putSelectionAt call should be removed. It seems to be overridden by the subsequent setCursor. I've been meaning to giv

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-04-17 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Monday, March 19, 2012 9:21 AM >I wonder whether in replaceAll whether the putSelectionAt call should be >removed. It seems to be overridden by the subsequent setCursor. I've been meaning to give a more in-depth look at this but haven't done s

Re: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-19 Thread Jean-Marc Lasgouttes
Le 10/03/12 07:09, Scott Kostyshak a écrit : So I suspect your patch is correct. OK, let me know if there's anything else I should test/investigate regarding this issue. Otherwise, I'll leave it in your hands. I wonder whether in replaceAll whether the putSelectionAt call should be removed.

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-09 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Friday, March 09, 2012 5:43 AM >The point was to fix bug 2068 > http://www.lyx.org/trac/ticket/2068 >which is related to spellchecker. [although I do not remember anything >about that :)] Interesting! That looks quite tricky. >However, thing

Re: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-09 Thread Jean-Marc Lasgouttes
Le 09/03/2012 11:21, Scott Kostyshak a écrit : From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, March 01, 2012 11:05 AM I would try to fix the actual place that modifies cursor, which is probably in findOne (lyxfind.cpp). replaceOne is the function called. What is the point of

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-09 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, March 01, 2012 11:05 AM >I would try to fix the actual place that modifies cursor, which is >probably in findOne (lyxfind.cpp). replaceOne is the function called. What is the point of the following code in CutAndPaste.cpp's function

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-02 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, March 01, 2012 11:05 AM >I would try to fix the actual place that modifies cursor, which is >probably in findOne (lyxfind.cpp). OK I will study this. Thanks for the guidance, Scott

Re: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-01 Thread Jean-Marc Lasgouttes
Le 01/03/2012 10:33, Scott Kostyshak a écrit : Is this the right fix? This fixes the bug that I just reported, but I'm worried that it would have unintended consequences for other functions that use LFUN_WORD_REPLACE. I would try to fix the actual place that modifies cursor, which is probably

[patch] LFUN_WORD_REPLACE does not clear selection

2012-03-01 Thread Scott Kostyshak
The bug this patch fixes can be reproduced as follows: 1. enable continuous spell check. 2. type a misspelled word and press space so that it has a wavy red underline. 3. right-click and choose a suggested replacement word. 4. press the backspace button. Result: nothing happens. If you press the b