Re: [patch] InsetCharstyle cosmetics

2004-11-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Juergen Spitzmueller wrote: >> >   I agree. It doesn't make sense for an inline element to have >> paragraphs > inside, because then it would not be an inline >> element. :-) >> >> I think all we need to do is to supress

Re: [patch] InsetCharstyle cosmetics

2004-11-01 Thread Juergen Spitzmueller
José Abílio Oliveira Matos wrote: > The text inset still has paragraphs inside, doesn't it? >   > Then the for cycle is not needed anymore as it is only a paragraph. But > it should be working. :-) OK, I'll just leave it as it is. Jürgen

Re: [patch] InsetCharstyle cosmetics

2004-11-01 Thread José Abílio Oliveira Matos
On Mon, Nov 01, 2004 at 10:27:38AM +0100, Juergen Spitzmueller wrote: > > The attached patch does just this (without the minibuffer message, for which I > haven't found an easy solution). > José, are your latest changes in ::docbook still necessary when paragraph > breaks are disabled? (sorry fo

Re: [patch] InsetCharstyle cosmetics

2004-11-01 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > The attached patch does just this (without the minibuffer message, for > which I haven't found an easy solution). I have committed this. Jürgen

Re: [patch] InsetCharstyle cosmetics

2004-11-01 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > >   I agree. It doesn't make sense for an inline element to have paragraphs > > inside, because then it would not be an inline element. :-) > > I think all we need to do is to supress LFUN_BREAKPARAGRAPH, > LFUN_BREAKPARAGRAPHKEEPLAYOUT and LFUN_BREAKPARAGRAPH_SKIP ins

Re: [patch] InsetCharstyle cosmetics

2004-10-31 Thread Juergen Spitzmueller
José Abílio Oliveira Matos wrote: > > BTW, as to your latest change: I think we should not allow paragraph > > breaks in the char style inset at all (leads to LaTeX error also and is > > not what inline insets are designed for IMO). > >   I agree. It doesn't make sense for an inline element to have

Re: [patch] InsetCharstyle cosmetics

2004-10-31 Thread José Abílio Oliveira Matos
On Sun, Oct 31, 2004 at 02:33:59PM +0100, Juergen Spitzmueller wrote: ... > Jürgen > > BTW, as to your latest change: I think we should not allow paragraph breaks in > the char style inset at all (leads to LaTeX error also and is not what inline > insets are designed for IMO). I agree. It doe

Re: [patch] InsetCharstyle cosmetics

2004-10-31 Thread Juergen Spitzmueller
José Abílio Oliveira Matos wrote: > But if you nest two of the them the inside style gets its label visible. > :-) I have the label working now. The inset font, though, seems to be a general problem (you can also see this in ERT, it gets only red/typewriter when nested, maybe also related: parag

Re: [patch] InsetCharstyle cosmetics

2004-10-31 Thread Martin Vermeer
On Sat, 30 Oct 2004 20:11:07 +0200 Juergen Spitzmueller <[EMAIL PROTECTED]> wrote: > These are just some minor cosmetics to make the char style inset look a > little > bit better, now that is usable again (most importantly: I have removed > the > left margin which really annoyed me all the time)

Re: [patch] InsetCharstyle cosmetics

2004-10-31 Thread José Abílio Oliveira Matos
On Sun, Oct 31, 2004 at 11:28:04AM +0100, Juergen Spitzmueller wrote: > > P.S.: Do you have any idea why the label does not get drawn? Also, getDrawFont > doesn't seem to work (provided that Noun should be drwan as small caps). But if you nest two of the them the inside style gets its label vi

Re: [patch] InsetCharstyle cosmetics

2004-10-31 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Hmmm, why did you set has_label_ to false? See InsetCharStyle::draw. Personally, I think it should be false (i.e. "collapsed") per default (pure aesthetical reasons; It annoys me to "collapse" all those char styles manually). But I do not really care. Jürgen P.S.: Do yo

Re: [patch] InsetCharstyle cosmetics

2004-10-31 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > |   if (has_label_) { > | + lyxerr << "params_type = " << params_.type << endl; > > Please conditionalize this one a debug flag. I will not commit this one. It's just for personal testing purposes. I try to get the label working again before committing

Re: [patch] InsetCharstyle cosmetics

2004-10-30 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | if (has_label_) { | + lyxerr << "params_type = " << params_.type << endl; Please conditionalize this one a debug flag. -- Lgb

[patch] InsetCharstyle cosmetics

2004-10-30 Thread Juergen Spitzmueller
These are just some minor cosmetics to make the char style inset look a little bit better, now that is usable again (most importantly: I have removed the left margin which really annoyed me all the time). Still missing: the label (not drawn for some reason I couldn't figure out yet). I will ap