Re: [patch] Fix gtk menu crash

2004-10-22 Thread John Spray
On Fri, 2004-10-22 at 14:40, Jean-Marc Lasgouttes wrote: > You should also get rid of this one: > > case MenuItem::Command: > { > FuncStatus const flag = > view_->getLyXFunc().getStatus(i->func()); Done, see revised p

Re: [patch] Fix gtk menu crash

2004-10-22 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: John> On Fri, 2004-10-22 at 13:49, Jean-Marc Lasgouttes wrote: >> Also, this status() method returns the right value for a submenu >> too. Therefore submenuDisabled is not needed at all. John> Wonderful! This makes the code much shorter. John

Re: [patch] Fix gtk menu crash

2004-10-22 Thread John Spray
On Fri, 2004-10-22 at 13:49, Jean-Marc Lasgouttes wrote: > Also, this status() method returns the right value for a submenu too. > Therefore submenuDisabled is not needed at all. Wonderful! This makes the code much shorter. I'll commit the attached patch if nobody objects. John Index: GMenu

Re: [patch] Fix gtk menu crash

2004-10-22 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: John> Hi, One could easily make the gtk frontend crash with a failed John> assertion in MenuBackend::Getmenu. The problem occurred when John> viewing a document with figures in it: the "Figures" submenu John> item didn't have a submenuname_ fi

[patch] Fix gtk menu crash

2004-10-03 Thread John Spray
Hi, One could easily make the gtk frontend crash with a failed assertion in MenuBackend::Getmenu. The problem occurred when viewing a document with figures in it: the "Figures" submenu item didn't have a submenuname_ field, but GMenubar::submenuDisabled always tries to get submenus by name from t