Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | + wa_ptr = (QWorkArea*)(this); | > No C-syle casts please. | > Use | > wa_ptr = const_cast(this); | | Right, I forgot about that, I'll fix it. Thanks a lot. -- Lgb

Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > NB: Qt4 files have been updated, but not tested. So changes might be | > needed. | | This patch goes in to fix compilation of Qt4. | | Abdel | Index: QWorkArea.C | =

Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > NB: Qt4 files have been updated, but not tested. So changes might be | > needed. | | This patch goes in to fix compilation of Qt4. | | Abdel | Index: QWorkArea.C | === | --- QWorkAre

Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : This patch replaces several of workarea signals with direct function calls into BufferView. This means that the dependency direction is changed, now the frontend depend on the core and not the other way around. (IMO more correct) As a added bonues this should be a

Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Yep, I never understood the reason for this wa_ptr... If someone coud | explain me a bit about that I will certainly remove it. It seems it is used as a trick to get a pointer to the WorkArea usable from some C callback function(s). | Then, in this

Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, Apr 13, 2006 at 08:03:23PM +0200, Lars Gullik Bjønnes wrote: | > Will go in shortly, but comments are appreciated. | | case SelectionClear: | lyxerr[Debug::GUI] << "Lost selection." << endl; |

Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, Apr 13, 2006 at 08:03:23PM +0200, Lars Gullik Bjønnes wrote: | > Will go in shortly, but comments are appreciated. | | case SelectionClear: | lyxerr[Debug::GUI] << "Lost selection." << endl; | if (wa_ptr) | -

Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Andre Poenitz
On Thu, Apr 13, 2006 at 08:03:23PM +0200, Lars Gullik Bjønnes wrote: > Will go in shortly, but comments are appreciated. case SelectionClear: lyxerr[Debug::GUI] << "Lost selection." << endl; if (wa_ptr) - wa_ptr->selectionLost(); +

Re: [patch] Change dependency direction for some workarea actions

2006-04-13 Thread Andre Poenitz
On Thu, Apr 13, 2006 at 08:03:23PM +0200, Lars Gullik Bjønnes wrote: > This patch replaces several of workarea signals with direct function > calls into BufferView. > > This means that the dependency direction is changed, now the frontend > depend on the core and not the other way around. (IMO more

[patch] Change dependency direction for some workarea actions

2006-04-13 Thread Lars Gullik Bjønnes
This patch replaces several of workarea signals with direct function calls into BufferView. This means that the dependency direction is changed, now the frontend depend on the core and not the other way around. (IMO more correct) As a added bonues this should be a bit faster as well... Will go