Re: [patch] Bug 5166

2008-10-24 Thread Uwe Stöhr
Vincent van Ravesteijn schrieb: without the typo.. thanks, it's in. regards Uwe

Re: [patch] Bug 5166

2008-10-24 Thread Vincent van Ravesteijn
without the typo.. Index: src/Text3.cpp === --- src/Text3.cpp (revision 27090) +++ src/Text3.cpp (working copy) @@ -1414,6 +1414,9 @@ doInsertInset(cur, this, cmd, true, true); cur.posForward(); + // If some text is moved into

Re: [patch] Bug 5166

2008-10-24 Thread Vincent van Ravesteijn
On Fri, 2008-10-24 at 22:57 +0200, Uwe Stöhr wrote: > Your patch work and I have comitted it: > http://www.lyx.org/trac/changeset/27090 > > > + if (content) > > + cur.backwardPos(); > > Things like this should be documented in the code by comments (why do we do > what

Re: [patch] Bug 5166

2008-10-24 Thread Uwe Stöhr
Your patch work and I have comitted it: http://www.lyx.org/trac/changeset/27090 > + if (content) > + cur.backwardPos(); Things like this should be documented in the code by comments (why do we do what?). thanks and regards Uwe

Re: [patch] Bug 5166

2008-10-24 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > Patch to solve bug 5166. > > doInsertInset has the behaviour to put the cursor inside the new inset > when there was no selection, thus when the new inset is empty. If there > was a selection, the cursor is put outside the inset. > > cur.backwardPos() puts the curs

[patch] Bug 5166

2008-10-23 Thread Vincent van Ravesteijn
Patch to solve bug 5166. doInsertInset has the behaviour to put the cursor inside the new inset when there was no selection, thus when the new inset is empty. If there was a selection, the cursor is put outside the inset. cur.backwardPos() puts the cursor inside the inset and doInsertInset(cmd_ca