Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: > Helge Hafting wrote: >> Perhaps something like [tabular lost!] or >> [tabular paste currently unsupported], >> so the user won't wonder what went wrong. > > I really wouldn't paste error messages into a document. OK then. I thought we did something

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
Helge Hafting wrote: > Perhaps something like [tabular lost!] or > [tabular paste currently unsupported], > so the user won't wonder what went wrong. I really wouldn't paste error messages into a document. Jürgen

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Helge Hafting
Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: So I just let Cursor::selectionAsString return an empty docstring() with multi-cell selection. This breaks middle mouse pasting. Why not return something like "[tabular]" instead? Hm would you really want this? Perhaps something like [ta

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > > So I just let Cursor::selectionAsString return an empty docstring() > > with multi-cell selection. This breaks middle mouse pasting. > > Why not return something like "[tabular]" instead? Hm would you really want this? Jürgen

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: > So I just let Cursor::selectionAsString return an empty docstring() > with multi-cell selection. This breaks middle mouse pasting. Why not return something like "[tabular]" instead? JMarc

[patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
As you can reproduce with the attached test case, branch crashes if you select all the cells starting from the last cell ending up in the first. The reason is that Cursor::selectionAsString does not handle multiple cell selection and mixes the cursor positions in the starting and ending cells (r