> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc, can I commit this patch (it's reattached for
Juergen> information)? The remaining issue is not a regression (it's a
Juergen> drawback of changeRefsIfUnique from the beginning), so this
Juergen> could be fixed l
Juergen Spitzmueller wrote:
> Attached another version. I have noted a final drawback now, though: The
> refs are not changed in the master/child documents. It would be easy to go
> to the master by adding something like in fillWithBibKeys:
>
> /// if this is a child document and the parent
On Fri, Sep 29, 2006 at 10:26:52AM +0200, Jean-Marc Lasgouttes wrote:
> > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> Andre> On Thu, Sep 28, 2006 at 07:23:16AM +0200, Jean-Marc Lasgouttes
> Andre> wrote:
> >> > "Andre" == Andre Poenitz
> >> <[EMAIL PROTECTED]> writes:
> >>
>
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
Andre> On Thu, Sep 28, 2006 at 07:23:16AM +0200, Jean-Marc Lasgouttes
Andre> wrote:
>> > "Andre" == Andre Poenitz
>> <[EMAIL PROTECTED]> writes:
>>
Andre> Why not have a virtual function in the insets filling a list
Andre> and iterati
On Thu, Sep 28, 2006 at 07:23:16AM +0200, Jean-Marc Lasgouttes wrote:
> > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> Andre> Why not have a virtual function in the insets filling a list
> Andre> and iterating over all insets in the buffer calling this
> Andre> function?
>
> Filli
Jean-Marc Lasgouttes wrote:
> Juergen> I thought it is better to not go the complicated way if the
> Juergen> inset contains only one item (which should be the common
> Juergen> case). That's my real life thinking perhaps. I can delete the
> Juergen> first statement if you wish. In theory, it shoul
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
Andre> Why not have a virtual function in the insets filling a list
Andre> and iterating over all insets in the buffer calling this
Andre> function?
Filling a list of what? Something like InsetBse::fillSomeList?
JMarc
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
Andre> On Wed, Sep 27, 2006 at 02:16:01PM +0200, Juergen Spitzmueller
Andre> wrote:
>> It would be easier if nextInset() would not return InsetBase, but
>> the real inset. Any idea to simplify it further?
Andre> Huh?
Andre> InsetBase _is
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>> I would have thought that the 'else' part is enough. Is it
>> necessary to handle the case where there is no ','?
Juergen> I thought it is better to not go the complicated way if the
Juergen> inset contains only one item (whic
On Wed, Sep 27, 2006 at 03:03:44PM +0200, Jean-Marc Lasgouttes wrote:
> > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>
> Juergen> Attached is what I have so far. Please keep on commenting.
>
> Very good. Let's start from there, then.
>
> --- src/insets/insetcommand.h
On Wed, Sep 27, 2006 at 12:16:33PM +0200, Jean-Marc Lasgouttes wrote:
> > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>
> Juergen> "Changing the citation key does not update references to it"
> Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=2744
>
> Juergen> The attached p
On Wed, Sep 27, 2006 at 02:16:01PM +0200, Juergen Spitzmueller wrote:
> It would be easier if nextInset() would not return InsetBase, but the real
> inset. Any idea to simplify it further?
Huh?
InsetBase _is_ an inset.
Andre'
Jean-Marc Lasgouttes wrote:
> Very good. Let's start from there, then.
>
> --- src/insets/insetcommand.h (Revision 15150)
> +++ src/insets/insetcommand.h (Arbeitskopie)
> @@ -72,6 +72,8 @@
>p_.setContents(c);
>}
> ///
> + void replaceC
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Attached is what I have so far. Please keep on commenting.
Very good. Let's start from there, then.
--- src/insets/insetcommand.h (Revision 15150)
+++ src/insets/insetcommand.h (Arbeitskopie)
@@ -72,6 +72,8 @@
Jean-Marc Lasgouttes wrote:
> Some comments:
>
> -void Buffer::changeRefsIfUnique(string const & from, string const & to)
> +void Buffer::changeRefsIfUnique(string const & from, string const & to,
> InsetBase::Code code)
>
> I do not like passing an inset code if it is not really generic (the
>
Georg Baum wrote:
> Does using of changeRefsIfUnique mean that it does not have the copy/paste
> problems I described in the bug report?
Yes, in the sense that it only changes refs and citations when the given
label/bibitem is unique (so not if it has been duplicated by pasting).
However, my pat
Juergen Spitzmueller wrote:
> "Changing the citation key does not update references to it"
> http://bugzilla.lyx.org/show_bug.cgi?id=2744
>
> The attached patch against 1.4svn fixes the bug by extending
> changeRefsIfUnique. It works very nicely. OK for trunk and branch? (I have
> another fix for
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> "Changing the citation key does not update references to it"
Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=2744
Juergen> The attached patch against 1.4svn fixes the bug by extending
Juergen> changeRefsIfUnique. It wor
"Changing the citation key does not update references to it"
http://bugzilla.lyx.org/show_bug.cgi?id=2744
The attached patch against 1.4svn fixes the bug by extending
changeRefsIfUnique. It works very nicely. OK for trunk and branch? (I have
another fix for bug 1684 in the pipe).
Jürgen
Index:
19 matches
Mail list logo
