Re: [experimental patch] fix bug 1973

2005-12-17 Thread Jean-Marc Lasgouttes
Yes please apply the patch. I thought it was already in. JMarc

Re: [experimental patch] fix bug 1973

2005-12-16 Thread Georg Baum
Georg Baum wrote: > Jean-Marc Lasgouttes wrote: > >>> "Georg" == Georg Baum >>> <[EMAIL PROTECTED]> >>> writes: >> >> Georg> This is not how it works now (in 1.3 and 1.4), at least not for >> Georg> tables. Assuming that the table cells have no explicit font >> Georg> setting, we'll

Re: [experimental patch] fix bug 1973

2005-12-12 Thread Helge Hafting
This patch seems to do the same as the previous one I tested. As expected, the comments didn't change anything Helge Hafting

Re: [experimental patch] fix bug 1973

2005-12-12 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> This is not how it works now (in 1.3 and 1.4), at least not for > Georg> tables. Assuming that the table cells have no explicit font > Georg> setting, we'll get > > Georg> \textbf{bla}\b

Re: [experimental patch] fix bug 1973

2005-12-12 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This is not how it works now (in 1.3 and 1.4), at least not for Georg> tables. Assuming that the table cells have no explicit font Georg> setting, we'll get Georg> \textbf{bla}\begin{tabular}foo\end{tabular}\textbf{baz} In my view th

Re: [experimental patch] fix bug 1973

2005-12-10 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> The first problem which has not beed addressed yet is that > Georg> insets that return true in noFontChange() inherit the > Georg> environment font on screen but don't inherit it in the .

Re: [experimental patch] fix bug 1973

2005-12-09 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> The first problem which has not beed addressed yet is that Georg> insets that return true in noFontChange() inherit the Georg> environment font on screen but don't inherit it in the .tex Georg> output. This is fixed by the attached pat

Re: [experimental patch] fix bug 1973 works as advertised

2005-12-09 Thread Helge Hafting
On Fri, Dec 09, 2005 at 11:21:29AM +0100, Georg Baum wrote: > Jean-Marc Lasgouttes wrote: > > >> "Georg" == Georg Baum > >> <[EMAIL PROTECTED]> > >> writes: > > > > Georg> I wanted to be on the safe side and change as little as > > Georg> possible. Of course I could also iterate over

Re: [experimental patch] fix bug 1973

2005-12-09 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> I wanted to be on the safe side and change as little as > Georg> possible. Of course I could also iterate over the cells of each > Georg> inset containing text, but I am not sure if this

Re: [experimental patch] fix bug 1973

2005-12-08 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I wanted to be on the safe side and change as little as Georg> possible. Of course I could also iterate over the cells of each Georg> inset containing text, but I am not sure if this is the right Georg> thing to do (e.g. for collapsabl

Re: [experimental patch] fix bug 1973

2005-12-05 Thread Georg Baum
Am Montag, 5. Dezember 2005 12:42 schrieb Jean-Marc Lasgouttes: > I do not like the patch much. What is the new semantics of > setCharFont? It treats now a tabular inset also as a character. Of course we could also move this functionality into an extra method setInsetFont and call that always a

Re: [experimental patch] fix bug 1973

2005-12-05 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Am Mittwoch, 30. November 2005 13:49 schrieb Georg Baum: >> So this means the patch works. What needs to be done before it can >> be applied? Maybe change InsetTabular::setFont to a virtual >> function for Georg> all >> insets that doe

Re: [experimental patch] fix bug 1973

2005-12-04 Thread Georg Baum
Am Mittwoch, 30. November 2005 13:49 schrieb Georg Baum: > So this means the patch works. What needs to be done before it can be > applied? Maybe change InsetTabular::setFont to a virtual function for all > insets that does nothing in other insets? Ping! (updated patch attached) Georg diff -p

Re: [experimental patch] fix bug 1973

2005-11-30 Thread Georg Baum
Helge Hafting wrote: > My exact testcase (lyx qt, todays cvs): > 1. start lyx > 2. type "abc", insert table, type "abc" after the table, insert another > table, type "abc" after it. (This is all one big paragraph) > 3. In each table, type "abc" into the two first cells. > 4. Mark everything > 5.

Re: [experimental patch] fix bug 1973

2005-11-29 Thread Helge Hafting
Georg Baum wrote: Helge Hafting wrote: The output is now correct, but instead we sort of have the exact opposite problem: 1. Select _more_ than the table and apply a font change. Everything is correct, on screen and in output. 2. Select a few cells inside the changed table, and change

Re: [experimental patch] fix bug 1973

2005-11-28 Thread Georg Baum
Helge Hafting wrote: > The output is now correct, but instead we sort of have the > exact opposite problem: > > 1. Select _more_ than the table and apply a font change. Everything >is correct, on screen and in output. > > 2. Select a few cells inside the changed table, and change the font t

Re: [experimental patch] fix bug 1973

2005-11-27 Thread Helge Hafting
On Sat, Nov 26, 2005 at 09:30:25PM +0100, Georg Baum wrote: > Font changes are not propagated to tabulars, see > http://bugzilla.lyx.org/show_bug.cgi?id=1973. > > We have two problems here: > 1) InsetTabular::noFontChange() returns true, but that is not honored by > the on-screen font handling.

Re: [experimental patch] fix bug 1973

2005-11-26 Thread Alfredo Braunstein
Georg Baum wrote: > Font changes are not propagated to tabulars, see > http://bugzilla.lyx.org/show_bug.cgi?id=1973. > > We have two problems here: > 1) InsetTabular::noFontChange() returns true, but that is not honored by > the on-screen font handling. Therefore the font looks ok on screen. I >

[experimental patch] fix bug 1973

2005-11-26 Thread Georg Baum
Font changes are not propagated to tabulars, see http://bugzilla.lyx.org/show_bug.cgi?id=1973. We have two problems here: 1) InsetTabular::noFontChange() returns true, but that is not honored by the on-screen font handling. Therefore the font looks ok on screen. I don't know the font stuff well