Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-14 Thread Abdelrazak Younes
José Matos wrote: On Monday 14 May 2007 10:26:34 Jürgen Spitzmüller wrote: If you tested it well enough, it is ok for me. OK. Done. Abdel.

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-14 Thread José Matos
On Monday 14 May 2007 10:26:34 Jürgen Spitzmüller wrote: > If you tested it well enough, it is ok for me. OK. > Jürgen -- José Abílio

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-14 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Jose, Jurgen, what should I do with this patch? If you tested it well enough, it is ok for me. Jürgen

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-14 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Juergen Spitzmueller wrote: Abdelrazak Younes wrote: This patch does that and a bit more. It ensures that the coords are saved and restored in any case (closeEvent and buffer switching). It also does move the preamble related code in apply() and updateParam() in the ne

[Updated Patch] bug 3201: restore cursor position in preamble

2007-05-04 Thread Abdelrazak Younes
Juergen Spitzmueller wrote: Abdelrazak Younes wrote: This patch does that and a bit more. It ensures that the coords are saved and restored in any case (closeEvent and buffer switching). It also does move the preamble related code in apply() and updateParam() in the new PreambleModule class. Id

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-03 Thread Andre Poenitz
On Thu, May 03, 2007 at 11:43:01AM +0200, Abdelrazak Younes wrote: > Juergen Spitzmueller wrote: > >Abdelrazak Younes wrote: > > > >>This patch does that and a bit more. It ensures that the coords are > >>saved and restored in any case (closeEvent and buffer switching). It > >>also does move the pr

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-03 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Juergen Spitzmueller wrote: Abdelrazak Younes wrote: This patch does that and a bit more. It ensures that the coords are saved and restored in any case (closeEvent and buffer switching). It also does move the preamble related code in apply() and updateParam() in the ne

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-03 Thread Abdelrazak Younes
Juergen Spitzmueller wrote: Abdelrazak Younes wrote: This patch does that and a bit more. It ensures that the coords are saved and restored in any case (closeEvent and buffer switching). It also does move the preamble related code in apply() and updateParam() in the new PreambleModule class. Id

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-02 Thread Abdelrazak Younes
Juergen Spitzmueller wrote: Abdelrazak Younes wrote: This patch does that and a bit more. It ensures that the coords are saved and restored in any case (closeEvent and buffer switching). It also does move the preamble related code in apply() and updateParam() in the new PreambleModule class. Id

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-02 Thread Juergen Spitzmueller
Abdelrazak Younes wrote: > This patch does that and a bit more. It ensures that the coords are > saved and restored in any case (closeEvent and buffer switching). It > also does move the preamble related code in apply() and updateParam() in > the new PreambleModule class. Ideally I'd like all modu

Re: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-02 Thread Abdelrazak Younes
Leuven, E. wrote: also does move the preamble related code in apply() and updateParam() in the new PreambleModule class. Ideally I'd like all modules to follow the same route. and i guess we'd like the modules to have a changed() signal so that we don't have to connect the individual widgets

RE: [Updated Patch] bug 3201: restore cursor position in preamble

2007-05-02 Thread Leuven, E.
> also does move the preamble related code in apply() and updateParam() in > the new PreambleModule class. Ideally I'd like all modules to follow the > same route. and i guess we'd like the modules to have a changed() signal so that we don't have to connect the individual widgets to change_adap

[Updated Patch] bug 3201: restore cursor position in preamble

2007-05-02 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: Maybe. FWIW, here's the solution where the map is put into the controller (although I'm a bit reluctant at putting things in the controller where there's obviously qt4 to blame). Well, it's not as simple as that, you are asking the dialog to