Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-14 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Fri, Oct 06, 2006 at 10:52:31PM +0200, Abdelrazak Younes wrote: | >> If you prefer I can add this as a helper function in some | >> theFontLoader.h header: | >> | >> #include "frontends/Applica

Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-14 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Fri, Oct 06, 2006 at 10:52:31PM +0200, Abdelrazak Younes wrote: | >> If you prefer I can add this as a helper function in some | >> theFontLoader.h header: | >> | >> #include "frontends/Application.h" | >> #include "fronte

Re: Will commit now... (was Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-10 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sat, Oct 07, 2006 at 06:07:26PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes wrote: Andre Poenitz wrote: I think I'd prefer something like +x_ += theFontMetrics(font).width(&str[0], str.size()); Going 'optically' through four layers is not adding clarity. I

Re: Will commit now... (was Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-09 Thread Andre Poenitz
On Sat, Oct 07, 2006 at 06:07:26PM +0200, Abdelrazak Younes wrote: > Abdelrazak Younes wrote: > >Andre Poenitz wrote: > >> > >>I think I'd prefer something like > >> > >> +x_ += theFontMetrics(font).width(&str[0], str.size()); > >> > >>Going 'optically' through four layers is not adding clarit

Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-08 Thread Abdelrazak Younes
Andre Poenitz wrote: On Fri, Oct 06, 2006 at 10:52:31PM +0200, Abdelrazak Younes wrote: If you prefer I can add this as a helper function in some theFontLoader.h header: #include "frontends/Application.h" #include "frontends/FontLoader.h" FontLoader & theFontLoader() { return theApp->

Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-08 Thread Andre Poenitz
On Fri, Oct 06, 2006 at 10:52:31PM +0200, Abdelrazak Younes wrote: > If you prefer I can add this as a helper function in some > theFontLoader.h header: > > #include "frontends/Application.h" > #include "frontends/FontLoader.h" > > FontLoader & theFontLoader() > { > return theApp->fontLoad

Will commit now... (was Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-07 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Andre Poenitz wrote: I think I'd prefer something like +x_ += theFontMetrics(font).width(&str[0], str.size()); Going 'optically' through four layers is not adding clarity. I can also provide this helper function if you want, no problem. But I guess that's not

Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-06 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Andre Poenitz wrote: I think I'd prefer something like +x_ += theFontMetrics(font).width(&str[0], str.size()); Going 'optically' through four layers is not adding clarity. I can also provide this helper function if you want, no problem. But I guess that's not

Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-06 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Oct 05, 2006 at 07:03:36PM +0200, Abdelrazak Younes wrote: --- src/frontends/font_metrics.h(revision 15255) +++ src/frontends/font_metrics.h(working copy) [...] This comment should be tretained somewhere. It is, in FontMetrics.h. + if (f

Re: [SVN updated patch] Introduce frontends/FontMetrics virtual interface

2006-10-06 Thread Andre Poenitz
On Thu, Oct 05, 2006 at 07:03:36PM +0200, Abdelrazak Younes wrote: > --- src/frontends/font_metrics.h (revision 15255) > +++ src/frontends/font_metrics.h (working copy) > [...] > -class LyXFont; > - > -/** > - * A namespace holding helper functions for determining > - * the screen dimensi