Re: [Patch] centralize error lists handling (was Re: [Patch] move errorList_ from LyXView to Buffer (was Re: [Patch] transfer boost signal connections from BufferView to LyXView)

Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > I think this is the right approach, but (always a but ;-)) I don't | > think we should use a string as index. Also the globalness of the list | > structure is not good. All buffers, conversion errrors will get mashed | > into the same structrue, so

Re: [Patch] centralize error lists handling (was Re: [Patch] move errorList_ from LyXView to Buffer (was Re: [Patch] transfer boost signal connections from BufferView to LyXView)

Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > Abdelrazak Younes wrote: | >> | >> This patch does that and it removes absolutely _no_ functionality. | >> Actually, I think it should speed-up _significantly_ the latex | >> compilation for e

Re: [Patch] centralize error lists handling (was Re: [Patch] move errorList_ from LyXView to Buffer (was Re: [Patch] transfer boost signal connections from BufferView to LyXView)

Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > Abdelrazak Younes wrote: | >> | >> This patch does that and it removes absolutely _no_ functionality. | >> Actually, I think it should speed-up _significantly_ the latex | >> compilation for example in case of problematic

[Patch] centralize error lists handling (was Re: [Patch] move errorList_ from LyXView to Buffer (was Re: [Patch] transfer boost signal connections from BufferView to LyXView)

Abdelrazak Younes wrote: Abdelrazak Younes wrote: This patch does that and it removes absolutely _no_ functionality. Actually, I think it should speed-up _significantly_ the latex compilation for example in case of problematic files. I am going tomorrow and I really don't have the time to w

Re: [Patch] move errorList_ from LyXView to Buffer (was Re: [Patch] transfer boost signal connections from BufferView to LyXView)

Abdelrazak Younes wrote: This patch does that and it removes absolutely _no_ functionality. Actually, I think it should speed-up _significantly_ the latex compilation for example in case of problematic files. I am going tomorrow and I really don't have the time to wait for Lars approval. I

Re: [Patch] move errorList_ from LyXView to Buffer (was Re: [Patch] transfer boost signal connections from BufferView to LyXView)

Abdelrazak Younes wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: TODO 2: The ErrorList mechanism is used wrongly in a number of place, most notably in "Converter.C". Instead of replacing the ErrorList in the "Buffer" class, the "Converter" class should maintain its own list instead

Re: [Patch] transfer boost signal connections from BufferView to LyXView

Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > Lars Gullik Bjønnes wrote: | >> Abdelrazak Younes <[EMAIL PROTECTED]> writes: | >> | >> | OK, here is my last patch before holidays (hopefully). | >> | | This one continue the drastic diet ope

[Patch] move errorList_ from LyXView to Buffer (was Re: [Patch] transfer boost signal connections from BufferView to LyXView)

Abdelrazak Younes wrote: Abdelrazak Younes wrote: Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | OK, here is my last patch before holidays (hopefully). | | This one continue the drastic diet operated on BufferView. It removes | all boost signal from BufferView::pi

Re: [Patch] transfer boost signal connections from BufferView to LyXView

Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > Lars Gullik Bjønnes wrote: | >> Abdelrazak Younes <[EMAIL PROTECTED]> writes: | >> | >> | OK, here is my last patch before holidays (hopefully). | >> | | This one continue the drastic diet operated on BufferView. It remov

Re: [Patch] transfer boost signal connections from BufferView to LyXView

Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | The attached patch moves back the error_list_ to BufferView (not pimpl | because eventually I will merge it if no one beat me at this while I | am on holydays). Ok... only remember the reason for the pimpl split: compile

Re: [Patch] transfer boost signal connections from BufferView to LyXView

Abdelrazak Younes wrote: Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | OK, here is my last patch before holidays (hopefully). | | This one continue the drastic diet operated on BufferView. It removes | all boost signal from BufferView::pimpl and put them in LyXView.

Re: [Patch] transfer boost signal connections from BufferView to LyXView

Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | OK, here is my last patch before holidays (hopefully). | > | | This one continue the drastic diet operated on BufferView. It | > removes | > | all boost signal from Bu

Re: [Patch] transfer boost signal connections from BufferView to LyXView

Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | OK, here is my last patch before holidays (hopefully). | | This one continue the drastic diet operated on BufferView. It removes | all boost signal from BufferView::pimpl and put them in LyXView. | LyXView already inher

Re: [Patch] transfer boost signal connections from BufferView to LyXView

Abdelrazak Younes <[EMAIL PROTECTED]> writes: | OK, here is my last patch before holidays (hopefully). | | This one continue the drastic diet operated on BufferView. It removes | all boost signal from BufferView::pimpl and put them in LyXView. | LyXView already inherits from boost::signals::track

[Patch] transfer boost signal connections from BufferView to LyXView

OK, here is my last patch before holidays (hopefully). This one continue the drastic diet operated on BufferView. It removes all boost signal from BufferView::pimpl and put them in LyXView. LyXView already inherits from boost::signals::trackable so this is not a big deal. If you look closely a