Re: [Patch] Re: [Patch] partial support for units

2007-09-17 Thread Martin Vermeer
On Mon, 17 Sep 2007 13:53:03 +0200 Helge Hafting <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > On Fri, Sep 14, 2007 at 03:36:10PM +0200, Helge Hafting wrote: > > > >> "\unitfrac" supports a similiar optional argument for the number, but > >> that capability is not used in lyx. So we ca

Re: [Patch] Re: [Patch] partial support for units

2007-09-17 Thread Helge Hafting
Martin Vermeer wrote: On Fri, Sep 14, 2007 at 03:36:10PM +0200, Helge Hafting wrote: "\unitfrac" supports a similiar optional argument for the number, but that capability is not used in lyx. So we can now write $35\unitfrac{km}{h}$ but not $\unitfrac[35]{km}{h}$ The latter looks better, with

Re: [Patch] Re: [Patch] partial support for units

2007-09-15 Thread Martin Vermeer
On Fri, Sep 14, 2007 at 03:36:10PM +0200, Helge Hafting wrote: > Martin Vermeer wrote: ... > >I am not entirely happy with this patch. It works allright, but... > > > I tested this. Mostly fine, but a few small problems: > > Using "unit" gives two math boxes. One for the numer and one > for th

Re: [Patch] Re: [Patch] partial support for units

2007-09-14 Thread Martin Vermeer
On Fri, 14 Sep 2007 15:36:10 +0200 Helge Hafting <[EMAIL PROTECTED]> wrote: ... > > Here is a further patch, that Helge asked for (I think). It now does > > also non-fraction units (but still support is only partial). > > > > I am not entirely happy with this patch. It works allright, but... > >

Re: [Patch] Re: [Patch] partial support for units

2007-09-14 Thread Helge Hafting
Martin Vermeer wrote: On Tue, 11 Sep 2007 18:18:05 +0300 Martin Vermeer <[EMAIL PROTECTED]> wrote: On Tue, 11 Sep 2007 10:50:56 +0300 Martin Vermeer <[EMAIL PROTECTED]> wrote: On Tue, 11 Sep 2007 08:15:11 +0300 Martin Vermeer <[EMAIL PROTECTED]> wrote: On Mon, Sep 10, 2007 at

[Patch] Re: [Patch] partial support for units

2007-09-13 Thread Martin Vermeer
On Tue, 11 Sep 2007 18:18:05 +0300 Martin Vermeer <[EMAIL PROTECTED]> wrote: > On Tue, 11 Sep 2007 10:50:56 +0300 > Martin Vermeer <[EMAIL PROTECTED]> wrote: > > > On Tue, 11 Sep 2007 08:15:11 +0300 > > Martin Vermeer <[EMAIL PROTECTED]> wrote: > > > > > On Mon, Sep 10, 2007 at 10:42:32PM +0200,

Re: [Patch] partial support for units

2007-09-11 Thread Andre Poenitz
On Tue, Sep 11, 2007 at 07:41:29PM +0300, Martin Vermeer wrote: > On Tue, Sep 11, 2007 at 05:37:32PM +0200, Andre Poenitz wrote: > > On Tue, Sep 11, 2007 at 10:50:56AM +0300, Martin Vermeer wrote: > > > Here's a better one. > > > > Not really ;-) > > > > > Index: src/mathed/InsetMathFrac.cpp > >

Re: [Patch] partial support for units

2007-09-11 Thread Andre Poenitz
On Tue, Sep 11, 2007 at 05:58:56PM +0200, Jean-Marc Lasgouttes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > > The ShapeChanger changes the Shape back to the original state when it is > > destructed, i.e. the end of its scope. In this particular piece of code > > the scope of 'dummy2' is

Re: [Patch] partial support for units

2007-09-11 Thread Martin Vermeer
On Tue, Sep 11, 2007 at 05:58:56PM +0200, Jean-Marc Lasgouttes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > > The ShapeChanger changes the Shape back to the original state when it is > > destructed, i.e. the end of its scope. In this particular piece of code > > the scope of 'dummy2' is

Re: [Patch] partial support for units

2007-09-11 Thread Martin Vermeer
On Tue, Sep 11, 2007 at 05:37:32PM +0200, Andre Poenitz wrote: > On Tue, Sep 11, 2007 at 10:50:56AM +0300, Martin Vermeer wrote: > > Here's a better one. > > Not really ;-) > > > Index: src/mathed/InsetMathFrac.cpp > > === > > --- sr

Re: [Patch] partial support for units

2007-09-11 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > The ShapeChanger changes the Shape back to the original state when it is > destructed, i.e. the end of its scope. In this particular piece of code > the scope of 'dummy2' is the 'if' branch, i.e. the shape will already be > restored before cell(0).metric

Re: [Patch] partial support for units

2007-09-11 Thread Andre Poenitz
On Tue, Sep 11, 2007 at 10:50:56AM +0300, Martin Vermeer wrote: > Here's a better one. Not really ;-) > Index: src/mathed/InsetMathFrac.cpp > === > --- src/mathed/InsetMathFrac.cpp (revision 20193) > +++ src/mathed/InsetMathFrac.cpp

Re: [Patch] partial support for units

2007-09-11 Thread Martin Vermeer
On Tue, 11 Sep 2007 10:50:56 +0300 Martin Vermeer <[EMAIL PROTECTED]> wrote: > On Tue, 11 Sep 2007 08:15:11 +0300 > Martin Vermeer <[EMAIL PROTECTED]> wrote: > > > On Mon, Sep 10, 2007 at 10:42:32PM +0200, Andre Poenitz wrote: > > > On Mon, Sep 10, 2007 at 10:44:01PM +0300, Martin Vermeer wrote:

Re: [Patch] partial support for units

2007-09-11 Thread Martin Vermeer
On Tue, 11 Sep 2007 08:15:11 +0300 Martin Vermeer <[EMAIL PROTECTED]> wrote: > On Mon, Sep 10, 2007 at 10:42:32PM +0200, Andre Poenitz wrote: > > On Mon, Sep 10, 2007 at 10:44:01PM +0300, Martin Vermeer wrote: > > > OK for trunk? Here's a better one. - Martin Index: src/mathed/InsetMathFrac.h ==

Re: [Patch] partial support for units

2007-09-10 Thread Martin Vermeer
On Mon, Sep 10, 2007 at 10:42:32PM +0200, Andre Poenitz wrote: > On Mon, Sep 10, 2007 at 10:44:01PM +0300, Martin Vermeer wrote: > > OK for trunk? > > > Index: src/mathed/InsetMathFrac.cpp > > === > > --- src/mathed/InsetMathFrac.cpp

Re: [Patch] partial support for units

2007-09-10 Thread Andre Poenitz
On Mon, Sep 10, 2007 at 10:44:01PM +0300, Martin Vermeer wrote: > OK for trunk? > Index: src/mathed/InsetMathFrac.cpp > === > --- src/mathed/InsetMathFrac.cpp (revision 20193) > +++ src/mathed/InsetMathFrac.cpp (working copy

[Patch] partial support for units

2007-09-10 Thread Martin Vermeer
OK for trunk? - Martin Index: src/mathed/InsetMathFrac.h === --- src/mathed/InsetMathFrac.h (revision 20193) +++ src/mathed/InsetMathFrac.h (working copy) @@ -27,7 +27,8 @@ FRAC, OVER, ATOP, - NICEFRAC + NICEFRAC, + UNITF