On Fri, Jun 24, 2005 at 01:38:11PM +0200, Juergen Spitzmueller wrote:
> Martin Vermeer wrote:
> > Attached, please review
> >
> > - Martin
> > x.diff
> > Index: insettabular.C
> > ===
> > RCS file: /usr/local/lyx/cvsroot/lyx-devel/sr
Martin Vermeer wrote:
> Attached, please review
>
> - Martin
> x.diff
> Index: insettabular.C
> ===
> RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insettabular.C,v
> retrieving revision 1.464
> diff -u -p -r1.464 insettabula
Andre Poenitz wrote:
On Fri, May 06, 2005 at 11:57:47AM +0300, Martin Vermeer wrote:
I expect this would work fine if we could, in coordcache, turn bool
updating into int updating, counting the number of screen redraws we
have pending.
Best thing I can think of right now is some 'dispatch queue' wh
On Fri, May 06, 2005 at 11:57:47AM +0300, Martin Vermeer wrote:
> > Both seem to point so some asynchronous inconsistency.
> >
> > 1) how come another call to insettext draw happens after screen redraw
> > is already over?
> >
> > 2) Why two calls to doneUpdating, of which the second of course f
Martin Vermeer wrote:
>> As for "how?", well you pass m.base.textwidth to LyXText::metrics() from
>> InsetText::metrics(), but I'm damn sure you don't use it. (German "man",
>> French "on", English "you". We're much more direct :) And "one" just
>> sounds pretentious.)
>
> Oh yes, you (and me :) d
On Fri, 2005-05-06 at 12:05, Angus Leeming wrote:
> Martin Vermeer wrote:
> >> > Keeping the dim_ cache valid between phase 1 and 2 is (in theory...)
> >> > crucial for the whole drawing scheme...
> >>
> >> Yes, so
> >> dim_ = dim;
> >> dim.wid = m.base.textwidth;
> >> which is what this p
Martin Vermeer wrote:
>> > Keeping the dim_ cache valid between phase 1 and 2 is (in theory...)
>> > crucial for the whole drawing scheme...
>>
>> Yes, so
>> dim_ = dim;
>> dim.wid = m.base.textwidth;
>> which is what this patch proposes is just looking for trouble.
>
> How then to achiev
On Fri, 2005-05-06 at 11:37, Martin Vermeer wrote:
> Both seem to point so some asynchronous inconsistency.
>
> 1) how come another call to insettext draw happens after screen redraw
> is already over?
>
> 2) Why two calls to doneUpdating, of which the second of course fails?
Yes, I am gettin
Ãsh, incomplete patch. Attached is better.
- Martin
Index: BufferView_pimpl.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView_pimpl.C,v
retrieving revision 1.581
diff -u -p -r1.581 BufferView_pimpl.C
--- BufferView_pimpl
On Fri, 2005-05-06 at 09:28, Martin Vermeer wrote:
> On Thu, 2005-05-05 at 17:25, Juergen Spitzmueller wrote:
>
> >
> > 2. LyX asserts when you move the cursor to another cell with the mouse and
> > then type something _while_ the tabular dialog is opened.
> > I get two different asserts:
> >
>
On Fri, 2005-05-06 at 10:46, Angus Leeming wrote:
> >>
> >> tabular.getCellInset(cell)->metrics(m, dim);
> >> + if (!p_width.zero())
> >> + dim.wid = m.base.textwidth;
> >>
> >> Well, I can see what it does, but it seems a bit ugly. Surely, this
> >> should be happening inside
Andre Poenitz wrote:
> On Thu, May 05, 2005 at 03:09:36PM +0100, Angus Leeming wrote:
>> Martin Vermeer wrote:
>>
>> > Attached, please review
>> >
>> > - Martin
>>
>> tabular.getCellInset(cell)->metrics(m, dim);
>> + if (!p_width.zero())
>> + dim.wid = m.base.textwidth;
>>
>
On Fri, 2005-05-06 at 10:26, Andre Poenitz wrote:
> On Thu, May 05, 2005 at 03:09:36PM +0100, Angus Leeming wrote:
> > Martin Vermeer wrote:
> >
> > > Attached, please review
> > >
> > > - Martin
> >
> > tabular.getCellInset(cell)->metrics(m, dim);
> > + if (!p_width.zero())
> > +
On Thu, May 05, 2005 at 03:09:36PM +0100, Angus Leeming wrote:
> Martin Vermeer wrote:
>
> > Attached, please review
> >
> > - Martin
>
> tabular.getCellInset(cell)->metrics(m, dim);
> + if (!p_width.zero())
> + dim.wid = m.base.textwidth;
>
> Well, I can see what it does, but
On Thu, 2005-05-05 at 17:25, Juergen Spitzmueller wrote:
>
> 2. LyX asserts when you move the cursor to another cell with the mouse and
> then type something _while_ the tabular dialog is opened.
> I get two different asserts:
>
> a.)
> Assertion triggered in CoordCacheBase& CoordCache::insets
On Thu, May 05, 2005 at 03:09:36PM +0100, Angus Leeming wrote:
> Martin Vermeer wrote:
>
> > Attached, please review
> >
> > - Martin
>
> tabular.getCellInset(cell)->metrics(m, dim);
> + if (!p_width.zero())
> + dim.wid = m.base.textwidth;
>
> Well, I can see what it does, but
On Thu, May 05, 2005 at 04:25:07PM +0200, Juergen Spitzmueller wrote:
> Martin Vermeer wrote:
> > Attached, please review
>
> It works.
...but that's not necessarily good enough.
> I stepped on two (unrelated) things while testing:
>
> 1. Do you also see the drawing error in the first cell (bo
Am Donnerstag, 5. Mai 2005 16:25 schrieb Juergen Spitzmueller:
> 1. Do you also see the drawing error in the first cell (borders) when
opening
> the tabular dialog? It disapperas when you type something. Missing
update?
I see this too.
Georg
Martin Vermeer wrote:
> Attached, please review
It works.
I stepped on two (unrelated) things while testing:
1. Do you also see the drawing error in the first cell (borders) when opening
the tabular dialog? It disapperas when you type something. Missing update?
2. LyX asserts when you move the
Martin Vermeer wrote:
> Attached, please review
>
> - Martin
tabular.getCellInset(cell)->metrics(m, dim);
+ if (!p_width.zero())
+ dim.wid = m.base.textwidth;
Well, I can see what it does, but it seems a bit ugly. Surely, this should
be happening inside of InsetText? Also, if
Attached, please review
- Martin
Index: insettabular.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insettabular.C,v
retrieving revision 1.464
diff -u -p -r1.464 insettabular.C
--- insettabular.C 26 Apr 2005 11:12:19
21 matches
Mail list logo
