Re: [Patch] Re: [Patch] bug 675: caption insertion

2006-05-05 Thread Jose' Matos
On Friday 05 May 2006 15:59, Martin Vermeer wrote: > > 4. Lars will be a tiny little bit happier. So do I. > - Martin -- José Abílio

Re: [Patch] Re: [Patch] bug 675: caption insertion

2006-05-05 Thread Martin Vermeer
On Fri, May 05, 2006 at 02:59:56PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> This is the patch where the counter misbehaviour is fixed. I > Martin> gave it some testing and it appears to work OK. But as this is > Martin> much more

Re: [Patch] Re: [Patch] bug 675: caption insertion

2006-05-05 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> This is the patch where the counter misbehaviour is fixed. I Martin> gave it some testing and it appears to work OK. But as this is Martin> much more intrusive (it actually replaces caption layout by Martin> caption inset!) it wi

[Patch] Re: [Patch] bug 675: caption insertion

2006-05-05 Thread Martin Vermeer
On Fri, May 05, 2006 at 09:57:09AM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Now I have implemented this "float type sensing" as well as > Martin> getting the counter value. It all appears to work thanks to > Martin> the existing

Re: [Patch] bug 675: caption insertion

2006-05-05 Thread Martin Vermeer
On Fri, 2006-05-05 at 09:57 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Now I have implemented this "float type sensing" as well as > Martin> getting the counter value. It all appears to work thanks to > Martin> the existing infrast

Re: [Patch] bug 675: caption insertion

2006-05-05 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Now I have implemented this "float type sensing" as well as Martin> getting the counter value. It all appears to work thanks to Martin> the existing infrastructure. How does the counter works? I do not see how you do it outside

Re: [Patch] bug 675: caption insertion

2006-05-05 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> It's in. Log: So, now that it is in, can you tell us what makes this better than what we have currently? I am a bit skeptical that it really helps... JMarc

Re: [Patch] bug 675: caption insertion

2006-05-04 Thread Martin Vermeer
On Thu, 2006-05-04 at 15:26 +0300, Martin Vermeer wrote: ... > I propose to just check this in (cannot harm) and take it from there. > > - Martin It's in. Log: Restore the caption inset to functionality on-screen * insetcaption.[Ch] (InsetCaption::draw): draw label wi

Re: [Patch] bug 675: caption insertion

2006-05-04 Thread Martin Vermeer
On Thu, May 04, 2006 at 11:41:55AM +0200, Georg Baum wrote: > Martin Vermeer wrote: > > > On Thu, 2006-05-04 at 11:24 +0200, Georg Baum wrote: > >> Why is the mutable label needed? > > > > Because it complains otherwise: > > OK, I did not really ask what I wanted to know. Second try: Why do you

Re: [Patch] bug 675: caption insertion

2006-05-04 Thread Georg Baum
Martin Vermeer wrote: > On Thu, 2006-05-04 at 11:24 +0200, Georg Baum wrote: >> Why is the mutable label needed? > > Because it complains otherwise: OK, I did not really ask what I wanted to know. Second try: Why do you need to set the label in draw()? Why not set it in read() and whenever the c

Re: [Patch] bug 675: caption insertion

2006-05-04 Thread Martin Vermeer
On Thu, 2006-05-04 at 11:24 +0200, Georg Baum wrote: > Martin Vermeer wrote: > > > If no objection, this goes in presently. Should not have any functional > > effects at present, with insetcaption disabled... > > Note that you can opeen a file that contains an InsetCaption just fine, so > it is n

Re: [Patch] bug 675: caption insertion

2006-05-04 Thread Georg Baum
Martin Vermeer wrote: > If no objection, this goes in presently. Should not have any functional > effects at present, with insetcaption disabled... Note that you can opeen a file that contains an InsetCaption just fine, so it is not entirely disabled. Why is the mutable label needed? Georg

Re: [Patch] bug 675: caption insertion

2006-05-04 Thread Martin Vermeer
On Wed, 2006-05-03 at 22:05 +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | The attached was posted on bugzilla to fix the problem when people press > | Enter before or after an inset (inside float) in the hope of getting a > | caption in the right place. It is

Re: [Patch] bug 675: caption insertion

2006-05-03 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | The attached was posted on bugzilla to fix the problem when people press | Enter before or after an inset (inside float) in the hope of getting a | caption in the right place. It is an incomplete fix but will work for | the most common use cases, includ

[Patch] bug 675: caption insertion

2006-05-03 Thread Martin Vermeer
The attached was posted on bugzilla to fix the problem when people press Enter before or after an inset (inside float) in the hope of getting a caption in the right place. It is an incomplete fix but will work for the most common use cases, including the one Uwe described. BTW shouldn't we be mov