Re: [Patch] bug 2019 fix

2006-01-28 Thread Martin Vermeer
On Sat, Jan 28, 2006 at 12:55:09PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> What happens is, that we first define a "background font" > Martin> against which the actual font will be reduced. It's > Martin> initialized to the layo

Re: [Patch] bug 2019 fix

2006-01-28 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> What happens is, that we first define a "background font" Martin> against which the actual font will be reduced. It's Martin> initialized to the layout font, then completed with the Martin> font(s) of paragraphs "above" it in a l

Re: [Patch] bug 2019 fix

2006-01-27 Thread Martin Vermeer
On Fri, Jan 27, 2006 at 02:11:16PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Now, what is the "inset's font contribution" for the main > Martin> text? Doesn't exist / is represented already by the buffer > Martin> font. > > It co

Re: [Patch] bug 2019 fix

2006-01-27 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > With the articleX layout, if I select a keyword charcter style, I > cannot set the color of a character to black (or it maybe that I can, > but it does not show on screen). I noticed this, too. However, it is not related to Martin's patch. Jürgen

Re: [Patch] bug 2019 fix

2006-01-27 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Fri, Jan 27, 2006 at 10:21:55AM +0100, Jean-Marc Lasgouttes Martin> wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Could you tell me in a few words why !isMainText() is needed? Martin> It isn't ac

Re: [Patch] bug 2019 fix

2006-01-27 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Now, what is the "inset's font contribution" for the main Martin> text? Doesn't exist / is represented already by the buffer Martin> font. It could be initialized to the layout default font + buffer language. JMarc

Re: [Patch] bug 2019 fix

2006-01-27 Thread Martin Vermeer
On Fri, Jan 27, 2006 at 10:21:55AM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > Could you tell me in a few words why !isMainText() is needed? It isn't actually needed... I tried without and seems to work OK. But conversely allowing this call

Re: [Patch] bug 2019 fix

2006-01-27 Thread Georg Baum
Juergen Spitzmueller wrote: > Martin Vermeer wrote: >> So please, verify that this >> works for an unmodified tree too. > > Yes, it seems to fix the problem for me too. For me too. Georg

Re: [Patch] bug 2019 fix

2006-01-27 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Remember this was the bug you sort-of-promised to sort-of Martin> think about fixing in a better way than just disable font Martin> changes insite charstyle insets? I tried actually. I still have some patches in my tree (that di

Re: [Patch] bug 2019 fix

2006-01-27 Thread Martin Vermeer
On Fri, 2006-01-27 at 09:20 +0100, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > So please, verify that this > > works for an unmodified tree too. > > Yes, it seems to fix the problem for me too. Lars, Jean-Marc, can this go in? It's non-critical, but also trivial and well understood.

Re: [Patch] bug 2019 fix

2006-01-27 Thread Juergen Spitzmueller
Martin Vermeer wrote: > So please, verify that this > works for an unmodified tree too. Yes, it seems to fix the problem for me too. Jürgen

[Patch] bug 2019 fix

2006-01-26 Thread Martin Vermeer
Remember this was the bug you sort-of-promised to sort-of think about fixing in a better way than just disable font changes insite charstyle insets? Well, here is that fix. A fringe benefit of having to study the LyX font architecture in all its byzantine glory to help out with Helge's blue under