Re: [Patch] Unify groups LFUN (was: [LyX/master] Add missing break and polish formatting)

2018-02-07 Thread Pavel Sanda
Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: > >>> Here is what I had in mind. Works quite well. > >> Who would have guessed what the innocent commit of such esoteric lfun > >> would trigger :) > > > > It is still small activity :) Does it work for you? > > Will try tomorrow. Your patch work

Re: [Patch] Unify groups LFUN

2018-02-07 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: >> This is what I come up with, if (!from.nextInset()) line is taken from >> inset-forall but I have actually no idea what situation it handles. >> Comments? > > This looks reasonable. The test you mention is to make sire that at any > time the cursor is in front of an

Re: [Patch] Unify groups LFUN

2018-02-07 Thread Jean-Marc Lasgouttes
Le 07/02/2018 à 20:12, Pavel Sanda a écrit : Something like what inset-forall does? The idea is to use an InsetIterator (just a DocIterator that does forwardInset() with operator++ and returns the inset with operator*. Then one has to check the inset code by hand (which is not nice IMO). But I

[Patch] Unify groups LFUN (was: [LyX/master] Add missing break and polish formatting)

2018-02-07 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: >>> Here is what I had in mind. Works quite well. >> Who would have guessed what the innocent commit of such esoteric lfun >> would trigger :) > > It is still small activity :) Does it work for you? Will try tomorrow. >> But since I caught your attention, would you mi