Re: [Patch] Re: qt4: lyx hangs

2006-07-10 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Georg Baum <[EMAIL PROTECTED]> writes: | > What about this: | | > + updateMetrics(flags & Update::SinglePar); | > if ((flags & (Update::FitCursor | | > Update

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Georg Baum <[EMAIL PROTECTED]> writes: | > What about this: | | > + updateMetrics(flags & Update::SinglePar); | > if ((flags & (Update::FitCursor | | > Update::MultiParSel)) | >

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Georg Baum <[EMAIL PROTECTED]> writes: What about this: + updateMetrics(flags & Update::SinglePar); if ((flags & (Update::FitCursor | Update::MultiParSel)) && (fitCursor() || multiParSel())) {

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Am Sonntag, 9. Juli 2006 18:44 schrieb Abdelrazak Younes: | > I see. Then there were a reason why updateMetrics() was before | > fitCursor(). Two solution there: | | Yes. | | > 1) re-order the logic so that fitCursor() is called after | > updateMetrics(

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Georg Baum
Am Sonntag, 9. Juli 2006 18:44 schrieb Abdelrazak Younes: > I see. Then there were a reason why updateMetrics() was before > fitCursor(). Two solution there: Yes. > 1) re-order the logic so that fitCursor() is called after > updateMetrics() like it was before Lars changes. > > 2) remove the fi

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Georg Baum wrote: | > Am Sonntag, 9. Juli 2006 18:15 schrieb Lars Gullik Bjønnes: | > | >> No objections. Uinitialized class variables are bad. | > Indeed. Nevertheless I believe that we still have a logic problem: | > At the time when the coordcache

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Georg Baum wrote: | > Am Sonntag, 9. Juli 2006 18:15 schrieb Lars Gullik Bjønnes: | > | >> No objections. Uinitialized class variables are bad. | > Indeed. Nevertheless I believe that we still have a logic problem: | > At the time when the coordcache

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Abdelrazak Younes
Georg Baum wrote: Am Sonntag, 9. Juli 2006 18:15 schrieb Lars Gullik Bjønnes: No objections. Uinitialized class variables are bad. Indeed. Nevertheless I believe that we still have a logic problem: At the time when the coordcache is filled we should have calculated the metrics, and the widt

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | This patch fixes the crash and the bug. But I think that there is more | to it. I'll commit now if you don't object. I see that also scriptable is not initialized. Perhaps you can initialize that as well. Seems that

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Georg Baum
Am Sonntag, 9. Juli 2006 18:15 schrieb Lars Gullik Bjønnes: > No objections. Uinitialized class variables are bad. Indeed. Nevertheless I believe that we still have a logic problem: At the time when the coordcache is filled we should have calculated the metrics, and the width should therefore n

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | | Lars Gullik Bjønnes wrote: | | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | > | Georg Baum wrote: | | > | > Am Sonntag, 9. Juli 2006 12:35 schrieb Edwin Leuven: | | > | >> on inserting gre

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Georg Baum wrote: | > | > Am Sonntag, 9. Juli 2006 12:35 schrieb Edwin Leuven: | > | >> on inserting greek math symbol using the keyboard shortcuts | > | >> | > | >> a

Re: [Patch] Re: qt4: lyx hangs

2006-07-09 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Georg Baum wrote: | > | > Am Sonntag, 9. Juli 2006 12:35 schrieb Edwin Leuven: | > | >> on inserting greek math symbol using the keyboard shortcuts | > | >> | > | >> a

[Patch] Re: qt4: lyx hangs

2006-07-09 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Georg Baum wrote: | > Am Sonntag, 9. Juli 2006 12:35 schrieb Edwin Leuven: | >> on inserting greek math symbol using the keyboard shortcuts | >> | >> also hangs when inserting partial in a fraction, etc. | >> | >> gives m