On Fri, Jul 08, 2005 at 11:13:36AM +0200, Georg Baum wrote:
> This is now in. A working undo with cursor jump is better than a nonworking
> undo. We can still change that if anybody has a better idea.
Sensible choice.
Andre'
On Wed, Jul 06, 2005 at 10:26:49AM +0200, Georg Baum wrote:
> I am not sure what you meant exactly, but I exchanged recordUndo for
> recordUndoInset in some places.
Even better than what I had in mind. I forgot about recordUndoInset.
> The problem is that recordUndo only records changes to the cu
Georg Baum wrote:
> I am not sure what you meant exactly, but I exchanged recordUndo for
> recordUndoInset in some places. The problem is that recordUndo only
> records changes to the current cell, and that is wrong if we e. g. add a
> column. The attached patch fixes the undo problem in math grid
Andre Poenitz wrote:
> On Sun, Jul 03, 2005 at 11:03:23AM +0200, Georg Baum wrote:
>> BTW André, do you have any idea why undoing an added column in mathed
>> does not work?
>
> If it does (and I can't check right now) possibly because of this
> special idx fixing.
>
> An in-scheme-workaround fo
Andre Poenitz wrote:
> On Sun, Jul 03, 2005 at 11:03:23AM +0200, Georg Baum wrote:
>> The attached patch adds some documentation, removes col_ and row_
>> again, fixes wrong index calculation for "delete-column" and even
>> fixes one further case of cursor misadjustment in insettabular. I am
>> g
On Sun, Jul 03, 2005 at 11:03:23AM +0200, Georg Baum wrote:
> Am Samstag, 2. Juli 2005 20:43 schrieb Andre Poenitz:
>
> > For grid-like structures it is sometimes convienient to extract row
> > and col from idx. So there are some helper functions. And sometimes
> > it is useful to give the user th
On Sat, Jul 02, 2005 at 11:23:44PM +0300, Martin Vermeer wrote:
> While most of what you write has merit, I respectfully want to play the
> devil's advocate with the attached patch, which just bites the bullet
> and re-writes all the idx()-as-lvalue statements. It eliminates idx_ and
> makes row_,
On Wed, Jun 29, 2005 at 10:46:18AM +0300, Martin Vermeer wrote:
> BTW Andre, I think this bug, and the ugly looks of this brute-force
> patch, tell us something about the choice of cursor position
> representation in cursor_slice...
Could as well be the lack of beer at certain times.
> I see tha
On Wed, Jun 29, 2005 at 03:51:32PM +0200, Georg Baum wrote:
> Martin Vermeer wrote:
>
> > Here is the patch, armed with comments for posterity.
>
> It works here, too, but I guess that there are similar problems in
> insettabular.
> I noticed that undo does not work for the copy-column operation:
Am Samstag, 2. Juli 2005 22:23 schrieb Martin Vermeer:
> But it is essentially mostly a dumb substitution exercise. What I want
> to argue is that this is a _fundamental_ fix for the need for (and
> sometimes wrong/missing) adjustments, not a kludge.
When I wrote my earlier mail I did not read th
Am Samstag, 2. Juli 2005 20:43 schrieb Andre Poenitz:
> For grid-like structures it is sometimes convienient to extract row and
> col from idx. So there are some helper functions. And sometimes it is
> useful to give the user the impression that row and col are primary
> because that's what the us
On Sat, Jul 02, 2005 at 08:43:22PM +0200, Andre Poenitz wrote:
> On Fri, Jul 01, 2005 at 11:43:45PM +0300, Martin Vermeer wrote:
> > OK, I see it now: idx_type should be a struct with two int members, .row
> > and .col. And suitable operator definitions added. No duplication of
> > information, and
On Fri, Jul 01, 2005 at 11:43:45PM +0300, Martin Vermeer wrote:
> OK, I see it now: idx_type should be a struct with two int members, .row
> and .col. And suitable operator definitions added. No duplication of
> information, and still "idx() = ..." will work. Does that sound like a
> plan?
I stil
On Fri, Jul 01, 2005 at 11:21:12PM +0300, Martin Vermeer wrote:
> On Fri, Jul 01, 2005 at 09:23:59PM +0200, Andre Poenitz wrote:
...
> > I don't agree with the idea of storing row and column in the cursor.
> > This duplicates information and will lead to synchronization troubles.
>
> Actually I
On Fri, Jul 01, 2005 at 09:23:59PM +0200, Andre Poenitz wrote:
> On Wed, Jun 29, 2005 at 10:48:02PM +0300, Martin Vermeer wrote:
> > On Wed, Jun 29, 2005 at 10:46:18AM +0300, Martin Vermeer wrote:
> >
> > ...
> >
> > > Here is the patch, armed with comments for posterity.
> >
> > And here a bet
On Wed, Jun 29, 2005 at 10:48:02PM +0300, Martin Vermeer wrote:
> On Wed, Jun 29, 2005 at 10:46:18AM +0300, Martin Vermeer wrote:
>
> ...
>
> > Here is the patch, armed with comments for posterity.
>
> And here a better one.
I don't agree with the idea of storing row and column in the cursor.
On Wed, Jun 29, 2005 at 10:48:02PM +0300, Martin Vermeer wrote:
> On Wed, Jun 29, 2005 at 10:46:18AM +0300, Martin Vermeer wrote:
>
> ...
>
> > Here is the patch, armed with comments for posterity.
>
> And here a better one.
>
Committed.
- Martin
pgpqvsA7C9RHy.pgp
Description: PGP signa
On Wed, Jun 29, 2005 at 10:46:18AM +0300, Martin Vermeer wrote:
...
> Here is the patch, armed with comments for posterity.
And here a better one.
- Martin
Index: cursor_slice.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src
On Wed, Jun 29, 2005 at 03:51:32PM +0200, Georg Baum wrote:
> Martin Vermeer wrote:
>
> > Here is the patch, armed with comments for posterity.
>
> It works here, too, but I guess that there are similar problems in
> insettabular.
Haven't checked...
> I noticed that undo does not work for the c
Georg Baum wrote:
> No, it is also there with your patch. You should apply it IMO, the
> declaration changes can be done easily later if needed.
I will. I just don't have access to my machine ATM.
Jürgen
Juergen Spitzmueller wrote:
> Georg Baum wrote:
>
>> I noticed that undo does not work for the copy-column operation: It does
>> nothing. Do you have any idea why that is the case?
>
> Could it be related to bug 1808, for which I sent a patch?
No, it is also there with your patch. You should ap
Georg Baum wrote:
> I noticed that undo does not work for the copy-column operation: It does
> nothing. Do you have any idea why that is the case?
Could it be related to bug 1808, for which I sent a patch?
Jürgen
Martin Vermeer wrote:
> Here is the patch, armed with comments for posterity.
It works here, too, but I guess that there are similar problems in
insettabular.
I noticed that undo does not work for the copy-column operation: It does
nothing. Do you have any idea why that is the case?
> What if in
On Tue, Jun 28, 2005 at 07:02:25PM +0300, Martin Vermeer wrote:
> On Tue, 2005-06-28 at 14:47, Martin Vermeer wrote:
> > On Tue, 2005-06-28 at 13:40, Helge Hafting wrote:
> > > I edited a math matrix, the cursor was somewhere in the first column.1.4
> > > crash edit->rows&columns->copy column cras
24 matches
Mail list logo
