Re: [Patch] Re: [Patch] non-existent CharStyle crash

2005-05-02 Thread Martin Vermeer
On Mon, May 02, 2005 at 03:25:39PM +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > Ehh, the _proper_ patch is this... > > I kind of like the idea (untested), but I think you should trigger an Alert > which tells the user that some charstyle insets haven't been found etc. Unfortuna

Re: [Patch] Re: [Patch] non-existent CharStyle crash

2005-05-02 Thread Martin Vermeer
On Mon, May 02, 2005 at 03:23:46PM +0200, Georg Baum wrote: > Martin Vermeer wrote: > > > Not if I have to do it... and shouldn't it be called > > SwitchCharStylesBetweenClasses then? (And would you call the adding of > > more warts upon warts 'fixing'?) > > While CutAndPaste.C is messy I think t

Re: [Patch] Re: [Patch] non-existent CharStyle crash

2005-05-02 Thread Georg Baum
Martin Vermeer wrote: > Not if I have to do it... and shouldn't it be called > SwitchCharStylesBetweenClasses then? (And would you call the adding of > more warts upon warts 'fixing'?) While CutAndPaste.C is messy I think that SwitchLayoutsBetweenClasses is quite readable. > Here is a solution t

Re: [Patch] Re: [Patch] non-existent CharStyle crash

2005-05-02 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Ehh, the _proper_ patch is this... I kind of like the idea (untested), but I think you should trigger an Alert which tells the user that some charstyle insets haven't been found etc. Jürgen

Re: [Patch] Re: [Patch] non-existent CharStyle crash

2005-05-02 Thread Martin Vermeer
On Mon, May 02, 2005 at 12:00:34PM +0300, Martin Vermeer wrote: ... > Here is a solution that is nearly as good. What it does is that upon > re-load, it turns it into an "Undef:" type charstyle inset, red for > attention. Yes, the lack of warning at the time of conversion is > unpleasant, but th

[Patch] Re: [Patch] non-existent CharStyle crash

2005-05-02 Thread Martin Vermeer
On Mon, May 02, 2005 at 09:16:40AM +0200, Georg Baum wrote: > Martin Vermeer wrote: > > > On Sat, Apr 30, 2005 at 03:25:09PM +0200, Juergen Spitzmueller wrote: > >> What does it do with the contents of such charstyles? Transform it to > >> containing layout? Also, shouldn't the warning be the same