Re: [Patch] Math bitmaps for DocBook export

2005-03-01 Thread Georg Baum
Am Montag, 28. Februar 2005 17:04 schrieb Andreas Vox: > Angus Leeming <[EMAIL PROTECTED]> writes: > > > * Can the user turn off this image generation or does he have to install > > preview-latex? I see no lyxrc option. > > You need to define the converters lyxpreview->PNG and lyxpreview->EPS. >

Re: [Patch] Math bitmaps for DocBook export

2005-02-28 Thread Angus Leeming
Andreas Vox wrote: >> Surely you should check whether the snippets were generated successfully >> before adding them to 'addBitmaps' ? > > Yes, and since startAndWait() returns the return code of the script call > anyway, it's as simple as > > if (snipp->startAndWait(buffer, fore, back, scale) =

Re: [Patch] Math bitmaps for DocBook export

2005-02-28 Thread Andreas Vox
Angus Leeming <[EMAIL PROTECTED]> writes: > > I think that the idea is fine. Questions that I think should be answered: > * Can the user turn off this image generation or does he have to install > preview-latex? I see no lyxrc option. You need to define the converters lyxpreview->PNG and lyxpre

Re: [Patch] Math bitmaps for DocBook export

2005-02-28 Thread Angus Leeming
Jose' Matos wrote: >> > In this cases the changes only affect the docbook export. >> >> Please hang on. The code currently leaks memory. I'm about to post a >> 'better' version. > > It was never my intent to commit anything without hearing you. :-) Ok. > My comment was related with the doc

Re: [Patch] Math bitmaps for DocBook export

2005-02-28 Thread Jose' Matos
On Monday 28 February 2005 12:39, Angus Leeming wrote: > > > > In this cases the changes only affect the docbook export. > > Please hang on. The code currently leaks memory. I'm about to post a > 'better' version. It was never my intent to commit anything without hearing you. :-) My comment

Re: [Patch] Math bitmaps for DocBook export

2005-02-28 Thread Angus Leeming
Jose' Matos wrote: >> If Angus and Jose signs off on this then it is ok. > > Where do I sign? ;-) > >> And Andre for the math stuff. > > In this cases the changes only affect the docbook export. Please hang on. The code currently leaks memory. I'm about to post a 'better' version. -- Angu

Re: [Patch] Math bitmaps for DocBook export

2005-02-28 Thread Jose' Matos
On Sunday 27 February 2005 23:16, Lars Gullik Bjønnes wrote: > > If Angus and Jose signs off on this then it is ok. Where do I sign? ;-) > And Andre for the math stuff. In this cases the changes only affect the docbook export. -- José Abílio

Re: [Patch] Math bitmaps for DocBook export

2005-02-27 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | Hi! > | Here is the polished version of the snippet conversion patch. | Changes to last version: > | * no directories are created by accident | * creates bitmaps for more than one graphic format (currently PNG+EPS) | * create DocBook hooks for PNG, EPS, PD

Re: [Patch] Math bitmaps for DocBook export

2005-02-18 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Andreas Vox wrote: > >> I'm still waiting for the comments on whitespace ;-) > | I did not look at that. Shall I? ;-)) octet-stream patches are hard to look at... but I saw some missing whitespace in the patch snippets others has posted. Please comb your

Re: [Patch] Math bitmaps for DocBook export

2005-02-18 Thread Georg Baum
Andreas Vox wrote: > I'm still waiting for the comments on whitespace ;-) I did not look at that. Shall I? ;-)) > No. I use IsDirWriteable() as a shortcut for exists(path) && > isDirectory(path). If the directory already exists it gets reused. > So the above check means: > Check if I can use the

Re: [Patch] Math bitmaps for DocBook export

2005-02-17 Thread Andreas Vox
Georg Baum <[EMAIL PROTECTED]> writes: > > The patch looks good. Thanks! :-) > I think I found one little error and I have also some nitpicks I'm still waiting for the comments on whitespace ;-) > But in > general I would vote for inclusion. Great. > + if (it->isDirectory) { > +if

Re: [Patch] Math bitmaps for DocBook export

2005-02-17 Thread Georg Baum
The patch looks good. I think I found one little error and I have also some nitpicks ;-) But in general I would vote for inclusion. @@ -210,11 +216,21 @@ bool Exporter::Export(Buffer * buffer, s CopyStatus status = SUCCESS; for (vector::const_iterator it = files.begin(); it != files.en

Re: [Patch] Math bitmaps for DocBook export

2005-02-17 Thread Angus Leeming
[EMAIL PROTECTED] wrote: > Hi! > > Here's the final patch. It modifies the output routine for DocBook such > that bitmap files for math equations are exported to a directory > `filename + "_math"`. Looking at your code I see two things: 1. It factors out some code in PreviewLoader.C into a sepa

Re: [Patch] Math bitmaps for DocBook export

2005-02-17 Thread Jose' Matos
On Thursday 17 February 2005 11:39, [EMAIL PROTECTED] wrote: > Angus, I also have changes to lyxpreview2bitmap.py and > legacy_lyxpreview2png which allow the generation of PNG and EPS even if > dvipng is not present. I'll post > that as a separate patch. FWIW: - I would like to hear Lars